Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The windows with different sizes corners drawn incorrectly. #4

Open
llevkin opened this issue May 13, 2015 · 6 comments
Open

The windows with different sizes corners drawn incorrectly. #4

llevkin opened this issue May 13, 2015 · 6 comments

Comments

@llevkin
Copy link

llevkin commented May 13, 2015

As I understand it, the calculation of the height of the corners of the window comes on top of a couple of corners. If the height of the upper corners of the window and bottom different - there is a bug ...

@alaa-eddine
Copy link
Contributor

Can you please provide a screenshot or a live example.
not sure to understand what you mean :)

@llevkin
Copy link
Author

llevkin commented May 13, 2015

screen

Here... top and bottom corner and line have different height..

@alaa-eddine
Copy link
Contributor

I see what you mean now :)
actually, there is no simple way to handle different corners sizes.
because if I calculate the background height taking in consideration corner-tr and corner-br height, there will be the same problem if left corner and right corner have different size ....

the problem becomes worst if all corners have different sizes . this is why I assume that they all have same width/height.

there is a possible solution I see here, it'll be by adding possibility to change background paddings in all directions and accept negative paddings. in your case, a negative bottom bgPadding can solve the problem.

don't know if this workaround can fix your issue temporarly, but you can try to set bgPadding to negative value, it's not very clean but can avoid you waiting for the fix.

@llevkin
Copy link
Author

llevkin commented May 13, 2015

The task in which the four corners are of different sizes - can not be solved and absurd. The task in which the left and right angles are equal and the upper and lower heights are not equal - solved. Such a structure is quite common interface. I think you still need to choose the starting point for the bottom (left / right) and the top (left / right) to determine the angles of elevation.

@llevkin
Copy link
Author

llevkin commented May 13, 2015

But this is my imho, of course)

@alaa-eddine
Copy link
Contributor

yes this can be a solution, I'll see it don't add much complexity to the code.
it's important to stabilise the code in next updates so I can implement the new components : tabs, and text input are planed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants