Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2025-01-06 #54825

Closed
74 tasks done
github-actions bot opened this issue Jan 6, 2025 · 15 comments
Closed
74 tasks done

Deploy Checklist: New Expensify 2025-01-06 #54825

github-actions bot opened this issue Jan 6, 2025 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Release Version: 9.0.81-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 6, 2025
@francoisl
Copy link
Contributor

Demoting #54830 as NAB since the feature is behind a beta and is behind patched already (discussion)

@blimpich
Copy link
Contributor

blimpich commented Jan 6, 2025

Demoting #54845 b/c its behind a beta

@mountiny mountiny removed their assignment Jan 7, 2025
@mvtglobally
Copy link

Regression is at 60% complete

@izarutskaya
Copy link

Regression is at 77 % completed
QA team don't have Hybrid Android build

Unchecked PRs:
#54180 - failing on mWeb with original KI #54180 (comment)
#54252 - failing with issues #54252 (comment)
#54340 - found issue #54340 (comment)
#54653 - failing on Web with original KI #54653 (comment)
#54710 - failing with issues #54710 (comment)
#54734 - failing with issue #54734 (comment)

DB:
#54753
#54828
#54831
#54833
#54834
#54836
#54841
#54844
#54846
#54859
#54861
#54867

@mountiny
Copy link
Contributor

mountiny commented Jan 7, 2025

@joekaufmanexpensify is going to tst the internalQA later in the day

@amyevans
Copy link
Contributor

amyevans commented Jan 7, 2025

Demoting #54884 since it's behind a beta

@joekaufmanexpensify
Copy link
Contributor

checked off #54774

@joekaufmanexpensify
Copy link
Contributor

checked off #54433

@MarioExpensify
Copy link
Contributor

checked off #54885 (offending PR was reverted)

@izarutskaya
Copy link

izarutskaya commented Jan 7, 2025

Regression is at 2% left

Unchecked PRs:
#54098 - failing with original #54098 (comment)
#54180 - Repro in PROD, checking off #54180 (comment)
#54252 - failing with issues #54252 (comment)

#54275 - Pending validation on Web, Desktop
#54340 - found issue #54340 (comment)

#54370 - found issue on mWeb and iOS #54370 (comment) Pending validation on Android
#54409 - Pending validation on Android
#54412 - failing with #54412 (comment) Repro in PROD Can I check off ?
#54550 - checking off based on this comment #54550 (comment)
#54631 - Pending validation on iOS
#54653 - failing on Web with original KI #54653 (comment)

#54678 - Pending validation on Android
#54710 - failing with issues #54710 (comment)

#54734 -can I check off based this comment ?#54734 (comment)

DB:
#54753
#54879

@thienlnam
Copy link
Contributor

#54734 -can I check off based this comment ?#54734 (comment)

Yup this is fine, I've been checking off a few that fail original KIs that don't have any impact

@thienlnam
Copy link
Contributor

@izarutskaya / @mvtglobally I've cleared the deploy blockers, so all that is remaining is the Android validations for the PRs as well as one re-test of this issue

@mvtglobally
Copy link

Regression sis completed. Will post a last pending PR summary in a bit

@mvtglobally
Copy link

Unchecked PRs:
#54275 - Pending validation on Web, Desktop
#54409 - Pending validation on Android
#54631 - Pending validation on iOS
#54678 - Pending validation on Android
Checking 2 CPs
#54897 & #54921

@puneetlath
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests