Fix error on Android when submitting a tracked expense #54628
+144
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes an error on Android that appears when tracking a Distance expense, submitting a tracked expense to someone, categorizing it, or sharing it with an accountant.
It was caused by sending the receipt as an object
{ ... }
(not aFile
/Blob
), which is not supported byXMLHttpRequest
/FormData
.Fixed Issues
$ #45086
PROPOSAL: #45086 (comment)
Also related: #54154
Tests
Same as QA Steps
Offline tests
N/A
QA Steps
Unexpected error submitting/deleting this expense
error appears on the expensesUnexpected error submitting/deleting this expense
error appears on the expensesNote: If you see
Receipt scan incomplete. Please verify details manually.
error, it is related to #53839PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
45086.android.native.mp4
Android: mWeb Chrome
45086.android.chrome.mp4
iOS: Native
45086.ios.native.mp4
iOS: mWeb Safari
45086.ios.safari.mp4
MacOS: Chrome / Safari
45086.macos.safari.mov
MacOS: Desktop
45086.macos.desktop.mov