fix: smooth keyboard handling in BaseModal

[kirillzyusko]

Explanation of Change

Removed state-based animations and replace them with animations driven in a native thread for a better/optimized performance.

Fixed Issues

$ #54453
PROPOSAL:

Tests

• Launch ND or hybrid app
• Open DM
• Send a message to the DM if there is no message
• Tap on the composer if keyboard is not up
• Long tap on the message while keyboard is up
• Tap Add reaction button
• repeat Step 4 to 6 and be sure the emoji picker is not jumpy
• tap on Search field and make sure bottom sheet has an animated transition (for keyboard avoidance)

Offline tests

N/A

QA Steps

• Launch ND or hybrid app
• Open DM
• Send a message to the DM if there is no message
• Tap on the composer if keyboard is not up
• Long tap on the message while keyboard is up
• Tap Add reaction button
• repeat Step 4 to 6 and be sure the emoji picker is not jumpy
• tap on Search field and make sure bottom sheet has an animated transition (for keyboard avoidance)

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

BaseModal-better-animations.1.mov

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-24.at.18.09.32.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-24.at.18.17.31.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-24.at.18.21.17.mov

MacOS: Desktop

Screen.Recording.2024-12-24.at.18.25.24.mov

[melvin-bot]

@ntdiary Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[parasharrajat]

Note for me:

Special Test cases

1. Check for extra padding below the change skin bar on the emoji picker while searching for emoji on the picker itself.
2. Searching for emoji on the picker, keeps the picker above the keyboard.
3. iOS - Categories - Offline indicator overlaps with home bar in Default spend categories page 51544

[parasharrajat]

@kirillzyusko I noticed that the keyboard pops up for a short time before emoji picker is open. Can we prevent the immediate keyboard to show up while emoji picker is opening after the menu hides at 0.05 sec?

26.12.2024_00.41.18_REC.mp4

[kirillzyusko]

I noticed that the keyboard pops up for a short time before emoji picker is open. Can we prevent the immediate keyboard to show up while emoji picker is opening after the menu hides at 0.05 sec?

Did you test debug or release version? I can see such flickering in debug, but on release everything works fine 🤷‍♂️

[parasharrajat]

Let me check the release version.

[parasharrajat]

Yeah, it looks good on Release build.

[parasharrajat]

Screenshots

🔲 iOS / native

27.12.2024_21.14.37_REC.mp4

🔲 iOS / Safari

27.12.2024_21.16.32_REC.mp4

🔲 MacOS / Desktop

🔲 MacOS / Chrome

27.12.2024_03.24.33_REC.mp4

🔲 Android / Chrome

🔲 Android / native

27.12.2024_03.14.42_REC.mp4

[parasharrajat]

@kirillzyusko I believe we still have that issue on the Mobile browser. Even though I am testing on dev build but this might pop up again on lower-end devices as the logic is done that way. Looks like we are not suspending the keyboard while emoji picker is being opened from reactions. We should already have a logic to do that via ComposerFocusManager. Do you think we should disable the intermediate keyboard in this case?