Empty report submitted and appeared in LHN with GBR

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): expense

Action Performed:

1. Log in and observe LHN

Expected Result:

Reports should not be allowed to be submitted if they are empty.

Actual Result:

An empty report was successfully submitted by user and appeared in the LHN for approval with GBR

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[MitchExpensify]

It seems weird that the LHN row shows $10, but the report shows $0. @OfstadC do you recall the steps you took to submit this report? Do you see it showing as $0?

[OfstadC]

@MitchExpensify I don't remember 😬

This is what I see

I think I deleted something around that time? There was a RyanAir email (lingering spam from booking Expensicon flights for customers) that was added around the same time I deleted. Maybe that's tied to this? 🤔

I don't remember exact steps and I didn't notice the $0 report. But if it's tied to the Ryanair piece - I deleted that expense in Classic I think.

[MitchExpensify]

That's great context @OfstadC , was this an Expensify Travel booking?

[OfstadC]

The original Ryanair booking? It was from back when we booked travel manually for ExpensiCon guests. So I booked directly with Ryanair with my Expensify Card. I imagine the follow up emails and subsequent ads are being added as Travel documents/receipts (if there is an amount on them)? 🤔

[MitchExpensify]

I'm tempted to chalk this up to old travel booking weirdness and close it. Essentially it looks like a Ryanair promotional email was forwarded to receipts@, no amount was picked up by SmartScan, and that expense was added to a Trip. That trip then showed in @quinthar's account in an empty state.

[melvin-bot]

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

Coming back on this, it seems more likely related to the trip expense being deleted in OldDot. Can we even create trips like this anymore to try to reproduce @OfstadC ? My theory is that this happened because the deleted expense was on a trip and we don't delete the trip even though it is in an empty state

Possible steps to reproduce:

1. Create a trip
2. Submit an expense for the trip with a receipt
3. As the approver, confirm in NewDot that the trip and expense exist (i.e. Are not in an empty state)
4. As the submitter, delete the expense in OldDot
5. As the approver, confirm in NewDot if the expense exists in an empty state or not