Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-12-13 #54111

Closed
60 tasks done
github-actions bot opened this issue Dec 13, 2024 · 13 comments
Closed
60 tasks done

Deploy Checklist: New Expensify 2024-12-13 #54111

github-actions bot opened this issue Dec 13, 2024 · 13 comments
Assignees
Labels
Hourly KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024

Release Version: 9.0.76-12
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@luacmartins luacmartins added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 13, 2024
@francoisl
Copy link
Contributor

#54131 was fixed by #54136, checking both off

@izarutskaya
Copy link

Regression is at 3% left.

PRs:
#52333 - failing with #52333 (comment) check it off #52333 (comment)
#53385 - found KI #53385 (comment)
#53396 - failing with #53396 (comment)
#53949 - Known issue on mWeb only #52390
#54065 - failing with #54065 (comment)
#54073 - found KI #54073 (comment)
#54125, #54137 - checking new CPs

DB:
#54121
#54123
#54153
#54169
#54170

@rlinoz
Copy link
Contributor

rlinoz commented Dec 16, 2024

Checking off #54123 I tested and it is fixed by a CP.

@cristipaval
Copy link
Contributor

Checking off #54170, it is a backend issue and a fix PR is already open

@izarutskaya
Copy link

Regression is at 1% left.

PRs:
#52333 - Checking off based on comment #52333 (comment)
#53385 - Found issue, repro in PROD #53385 (comment) Checking off
#53396 - checking off by this comment #54127 (comment)
#53949 - Known issue on mWeb only, repro in PROD #52390 Checking off
#54065 - failing with #54065 (comment)
#54073 - found issue on Android only, repro in Prod #54073 (comment) Checking off

DB:
#54153
#54169

@mvtglobally
Copy link

Regression is completed

PRs:
#49907 - Seem to be a revert from an old build. Are we ok to check it off?
#54065 - failing with #54065 (comment)

Blockers:
#54153
#54169

@grgia
Copy link
Contributor

grgia commented Dec 16, 2024

#54065 is waiting on a retest
checking off #49907 as revert

@grgia
Copy link
Contributor

grgia commented Dec 16, 2024

demoting #54153

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 17, 2024
@grgia grgia added Hourly KSv2 and removed Monthly KSv2 labels Dec 17, 2024
@grgia grgia self-assigned this Dec 17, 2024
@mvtglobally
Copy link

@grgia Let us know if you need any additional checks from our side to move this checklist along

@luacmartins
Copy link
Contributor

@mvtglobally we're testing a revert in an attempt to fix the last blocker. We'll ping you once that's ready to be tested on your side too.

@luacmartins
Copy link
Contributor

@mvtglobally We're running 2 more CPs and once they are done could you please run a smoke test (just critical issues) on the build? We just want to make sure we didn't break anything critical with all the CPs

@grgia
Copy link
Contributor

grgia commented Dec 18, 2024

We're waiting on final confirmation from QA for the [smoke test].(https://expensify.slack.com/archives/C9YU7BX5M/p1734474444448929)

I plan to deploy as soon as that's done.

@grgia
Copy link
Contributor

grgia commented Dec 18, 2024

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hourly KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

8 participants