Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Private Domain Onboarding Check] create AddWorkEmail command #54080

Open
blimpich opened this issue Dec 12, 2024 · 9 comments
Open

[Private Domain Onboarding Check] create AddWorkEmail command #54080

blimpich opened this issue Dec 12, 2024 · 9 comments
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@blimpich
Copy link
Contributor

Implement backend command as per this section of the design doc: https://docs.google.com/document/d/1JlM9G3jZpaHDlcILWL9170ancMLtOnI2a73dQgX6ENo/edit?tab=t.0#heading=h.yfzpo4ycy65u

@blimpich blimpich added Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff labels Dec 12, 2024
@blimpich blimpich self-assigned this Dec 12, 2024
@blimpich
Copy link
Contributor Author

Working on this.

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

@blimpich Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@allgandalf
Copy link
Contributor

allgandalf commented Dec 16, 2024

heya @blimpich any ETA on this one? I have partial FE PR for the first screen here

Mainly i want to see how to hold to the work-email screen while the api is returning the value of shouldValidate

@blimpich
Copy link
Contributor Author

I hope to have this in by end of the week, I could probably get you working on my local version in a day or two. This is my number 1 issue right now, but writing the tests for it is taking awhile.

I imagine we we want to show a loading state until shouldValidate exists?

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
@blimpich
Copy link
Contributor Author

Making good progress on this. Most of the tests are written. Functionality is pretty much there. I need to add some onyx updates and add tests for those onyx updates. Test suite is running very slowly for some reason though, seems unrelated, but is slowing down progress.

@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
@blimpich
Copy link
Contributor Author

About ready to put this up for review, just need the Auth build to go green: https://github.com/Expensify/Auth/pull/13535. I think the web tests are flakes.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 20, 2024
@blimpich
Copy link
Contributor Author

Not overdue, working on this, getting very close

@melvin-bot melvin-bot bot removed the Overdue label Dec 23, 2024
@blimpich blimpich moved this from Todo to In Progress in [#whatsnext] #convert Dec 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 26, 2024
@blimpich
Copy link
Contributor Author

Merged Auth PR, working on Web PR

@melvin-bot melvin-bot bot removed the Overdue label Dec 26, 2024
@blimpich blimpich added the Reviewing Has a PR in review label Dec 27, 2024
@blimpich
Copy link
Contributor Author

Web PR merged. I have a small follow up PR for Auth but everything we need is in Auth and web now. We just need to get a web deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
Status: In Progress
Development

No branches or pull requests

2 participants