Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact picker in submit expense flow #53894

Open
dubielzyk-expensify opened this issue Dec 11, 2024 · 16 comments
Open

Update contact picker in submit expense flow #53894

dubielzyk-expensify opened this issue Dec 11, 2024 · 16 comments
Assignees
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2

Comments

@dubielzyk-expensify
Copy link
Contributor

Problem

From our recent usability studies and other observations we can see that people are struggling to submit to the right place.

Solution

Given most people would wanna submit to a workspace let's make a seperate section at the top for the workspaces that the user can submit to and also show who the approver would be:

image
image

Everything else remains the same

cc @Expensify/design @trjExpensify @JmillsExpensify

@dubielzyk-expensify dubielzyk-expensify added Daily KSv2 Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. labels Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@dubielzyk-expensify dubielzyk-expensify added NewFeature Something to build that is a new item. and removed Improvement Item broken or needs improvement. labels Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

Copy link

melvin-bot bot commented Dec 11, 2024

Current assignee @sakluger is eligible for the NewFeature assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Dec 11, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Dec 11, 2024

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

Copy link

melvin-bot bot commented Dec 11, 2024

Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

@trjExpensify
Copy link
Contributor

Oh, Is this for the participant selector in the Submit expense flow? If so, we're in the process of killing that now (and Track expense) as the A/B test of a consolidated Create expense performed better.

For Create expense we have this PR in review already for the updates in this issue.

@dubielzyk-expensify
Copy link
Contributor Author

It could be for Create expense too. I think we should probably merge the two mocks then?

@dannymcclain
Copy link
Contributor

Yeah I think we should just update this recipient screen for any/all expense flows.

@shawnborton
Copy link
Contributor

Definitely agree there

@shawnborton
Copy link
Contributor

I think the PR above does cover all the cases though, at least that's what it seemed like from running a quick test.

@trjExpensify
Copy link
Contributor

Yeah, so maybe for a follow-up PR with this issue, we can switch out Workspace for the submitsTo on the workspace rows?

image

@dubielzyk-expensify
Copy link
Contributor Author

Sounds good 👍 So which issue do we keep?

@trjExpensify
Copy link
Contributor

We can keep the other linked to the PR. I've added that to the OP:

image

@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@sakluger
Copy link
Contributor

I'm going to add this to the #convert project since it has to do with new customer adoption. Let me know if it should live elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering NewFeature Something to build that is a new item. Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

5 participants