[HOLD for payment 2024-12-30] [$250] Android & iOS - Expensify Card - Previous data is not cleared when issuing new card

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/5285123
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Expensify Card is set up.

Issue 1:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Tap on any member.
4. Tap New card.
5. Go through card issue flow and remember all the details.
6. After issuing the card, tap New card to issue another card.
7. Go through the card issue flow.
8. Note that the previous data entered in Step 5 is preserved and not reset.

Issue 2:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Expensify Card.
3. Tap Issue card.
4. Go through card issue flow.
5. After issuing the card, tap Issue card to issue another card.
6. Note that app shows the confirmation page from the previous card assignment instead of starting the flow with Step 1.

Expected Result:

When starting another card issue flow after issuing a card, the previous data will be cleared (production behavior).

Actual Result:

When starting another card issue flow after issuing a card, the previous data is preserved.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6681791_1733137032826.Issue_1.mp4

Bug6681791_1733137032831.Issue_2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021863614110562904926
• Upwork Job ID: 1863614110562904926
• Last Price Increase: 2024-12-02

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[koko57]

I can take a look

[Julesssss]

Ah, thanks Vit. I will unsub

[allgandalf]

@koko57 were you able to reproduce the 1st bug ?

[koko57]

@allgandalf I tested on web while my ios app is building - I cannot repro the first issue - after successfully issuing a card while I'm going through the flow I need to provide the new data BUT of course on Step 5 I will get the same value when issuing a physical card again - because we always default to "User's card"

but I wonder if it's only the mobile issue? TBH it should work the same

[allgandalf]

@mountiny was mentioning that we have not deployed native platforms since last 2 deploys. So there would be mismatch between web and native

[allgandalf]

I am getting a lot of mixed results here, I was able to reproduce the 1st one partially, I saw the value persisted but it went away in like ~2 seconds, and now i cannot reproduce it anymore

[koko57]

yet still there weren't any changes applied (that I'm at least aware of) that could cause such problem.

[koko57]

Ok, I was able to reproduce it. Digging now

[koko57]

Straaange, bc we are clearing the data from Onyx

• is there anything I don't see in these logs?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: clear previous data from Expensify Card flow #53867

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @kadiealexander @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Waiting for some clarification (will update soon)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Have a policy with Expensify cards enabled and bank account added

Test 1:

1. Go to workspace settings > Members.
2. Tap on any member.
3. Tap New card > Choose Expensify cards.
4. Go through card issue flow and remember all the details.
5. After issuing the card, tap New card to issue another card.
6. Go through the card issue flow.

Verify that you need to provide the data for the each step and the data from the previous flow is cleared.

Test 2:

1. Go to workspace settings > Expensify Card.
2. Tap Issue card button.
3. Go through the card issue flow.
4. After issuing the card, tap Issue card to issue another card.

Verify that the flow starts properly from the beginning

Do we agree 👍 or 👎

[allgandalf]

This hasn't occurred before the introduction ValidateCodeActionModal.

@koko57 Do you think that the validate code modal introduced this bug? I'm not sure about the offending PR for this issue:

[jliexpensify]

Kadie is OOO so I'll take care of checklist and payment

[melvin-bot]

Current assignee @allgandalf is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

Whoops didn't realise there was already a job created.

Payment Summary

• C+: @allgandalf $250 (to be paid via Upworks)

https://www.upwork.com/jobs/~021863614110562904926

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @koko57 is from an agency-contributor and not due payment
• ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@jliexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1863614110562904926/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[jliexpensify]

Bump @allgandalf to accept the offer please

[allgandalf]

Accepted @jliexpensify 😄

Note to self: Requested normal payment cause this issue didn’t belong to the current project and was some staging regression

[jliexpensify]

Paid and job closed!