[$250] Search - Search section loads infinitely when opened after logging in

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.68-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Open the Expensify app.
2. Log in with any Gmail account.
3. When logged in, tap on "Search" on the bottom of the screen.
4. Verify that search section and all the content in it, loads smoothly.

Expected Result:

Search section and all the content in it, should load smoothly when opened.

Actual Result:

Search section loads infinitely when opened just after logging in.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679422_1732821969147.Infinitelly.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021863519972369952192
• Upwork Job ID: 1863519972369952192
• Last Price Increase: 2024-12-02

Issue Owner

Current Issue Owner: @luacmartins

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

This is a BE Bug. Search API returns no Onyx data.

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search section loads infinitely when opened after logging in

What is the root cause of that problem?

We called the search API with this jsonQuery, but the response returned an empty onyxData array.

jsonQuery: {"type":"expense","status":"all","sortBy":"date","sortOrder":"desc","filters":null,"inputQuery":"type:expense status:all sortBy:date sortOrder:desc","hash":243428839,"recentSearchHash":422547233,"offset":0}

The reason for the empty onyxData array might be that the backend validated the query as having the wrong format or something similar.

And since onyxData is an empty array, shouldShowLoadingState always returns false, which is why the loading state is not hidden.

App/src/components/Search/index.tsx

Line 222 in 9933888

const shouldShowLoadingState = !isOffline && !isDataLoaded;

App/src/components/Search/index.tsx

Line 309 in 9933888

if (shouldShowLoadingState) {

What changes do you think we should make in order to solve the problem?

To resolve this issue, we need to do two things:

1. Double-check the JSON query to match the backend's requirements.
2. Handle the case where onyxData is an empty array.

App/src/components/Search/index.tsx

Line 308 in 9933888

//src/components/Search/index.tsx#L308
+    if (searchResults === undefined && !isOffline) {
+        setShouldShowStatusBarLoading(false);

+        return (
+            <View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
+                <EmptySearchView type={type} />
+            </View>
+        );
+    }

POC

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863519972369952192

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[mountiny]

cc @luacmartins @lakchote can you have a look into this?

[melvin-bot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

@daledah the requestID shared here shows no errors for that request. Do you have expense data in that account?

[akinwale]

@huult Could you clarify what you mean by "Double-check the JSON query to match the backend's requirements." in your proposed solution?

[huult]

@akinwale Yes, I mean we need to check with the backend why this JSON query has returned Onyx with an empty array, and this resolved it

[luacmartins]

This is entirely internal. So gonna unassign BZ and C+

[luacmartins]

This is fixed