Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concierge chat shows only most recent message and all other turns into an infinite skeleton #53277

Closed
1 of 8 tasks
m-natarajan opened this issue Nov 28, 2024 · 21 comments
Closed
1 of 8 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): expensify-quality

Action Performed:

  1. Open ND
  2. Go to Concierge chat

Expected Result:

All chats should be loading

Actual Result:

Concierge chat initially loads, then all but the most recent message turns into an infinite skeleton

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Please check in the channel

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @janicduplessis
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Nov 28, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Copy link

melvin-bot bot commented Nov 28, 2024

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 28, 2024

Triggered auto assignment to @techievivek (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 28, 2024
@RachCHopkins
Copy link
Contributor

I can't repro - Replied in thread.

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

@RachCHopkins, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@RachCHopkins
Copy link
Contributor

Per the above thread @janicduplessis is going to take a look at this.

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@techievivek
Copy link
Contributor

@janicduplessis Can you please comment on the GH so I can assign it to you, thanks.

@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Dec 3, 2024
@janicduplessis
Copy link
Contributor

I will have a look at this today

@janicduplessis
Copy link
Contributor

janicduplessis commented Dec 6, 2024

I'm having trouble reproducing this one.

Posted in slack:

Is anyone able to reproduce this on a new account? I've had no luck there.
From looking at the code the only way this kind of skeleton can show is when the state isLoadingInitialReportActions or isLoadingOlderReportActions is true, but I don't see any calls to GetOlderReportActions in the logs so it must be the first case. This is set to true when calling OpenReport
I've looked at the OpenReport calls from the logs for report id 4084426685399241 which is one of the problematic ones in the posted screenshots, it is hard to see exactly what is going on, I wonder if some race condition in SequentialQueue could cause the OpenReport response to never be processed.

@melvin-bot melvin-bot bot removed the Overdue label Dec 6, 2024
@trjExpensify
Copy link
Contributor

I wasn't able to repro it, but I've seen it multiple time in FS reviews.

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

@janicduplessis, @RachCHopkins, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 12, 2024

@janicduplessis @RachCHopkins @techievivek this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Dec 12, 2024

@janicduplessis, @RachCHopkins, @techievivek Huh... This is 4 days overdue. Who can take care of this?

@RachCHopkins
Copy link
Contributor

@janicduplessis I know you said in Slack that you were going to get into this again, how are you getting on?

@janicduplessis
Copy link
Contributor

Investigating this, @muttmuure said he has more cases to show me. Currently we think it might be related to OpenReport call never resolving.

Copy link

melvin-bot bot commented Dec 17, 2024

@janicduplessis, @RachCHopkins, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 17, 2024
@techievivek
Copy link
Contributor

techievivek commented Dec 18, 2024

Not overdue. @janicduplessis, are you looking into this? Any help you need from the backend for this?

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2024
Copy link

melvin-bot bot commented Dec 23, 2024

@janicduplessis, @RachCHopkins, @techievivek Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@RachCHopkins
Copy link
Contributor

Calm down Melvin, it's the holidays... 🎄

@melvin-bot melvin-bot bot removed the Overdue label Dec 23, 2024
Copy link

melvin-bot bot commented Dec 27, 2024

@janicduplessis, @RachCHopkins, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 27, 2024
@muttmuure
Copy link
Contributor

muttmuure commented Dec 29, 2024

Fix linked in thread, going to close!

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Dec 29, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed
Projects
Development

No branches or pull requests

7 participants