Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Report action says automatically approved $0.00 via #53037

Closed
1 of 8 tasks
m-natarajan opened this issue Nov 23, 2024 · 42 comments
Closed
1 of 8 tasks

[$250] Report action says automatically approved $0.00 via #53037

m-natarajan opened this issue Nov 23, 2024 · 42 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @flodnv
Slack conversation (hyperlinked to channel name): expensify-migrate

Action Performed:

  1. Have a report submitted and approved on a OD
  2. Open the report in ND

Expected Result:

Should show correct amount of the approved expense

Actual Result:

Report action says automatically approved $0.00 via

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (16)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861506983862256537
  • Upwork Job ID: 1861506983862256537
  • Last Price Increase: 2024-12-31
Issue OwnerCurrent Issue Owner: @c3024
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@me-ZaidAli
Copy link

@m-natarajan can you please be a bit more descriptive than OD and ND coz most of us new contributors don't know what that is?

@missbond2017
Copy link

- **ND/NewDot:** new.expensify.com
- **OD/OldDot:** expensify.com

@melvin-bot melvin-bot bot added the Overdue label Nov 26, 2024
@OfstadC
Copy link
Contributor

OfstadC commented Nov 26, 2024

Yeah definitely something weird going on with reports from OD showing on New

image image

@melvin-bot melvin-bot bot removed the Overdue label Nov 26, 2024
@OfstadC OfstadC added the External Added to denote the issue can be worked on by a contributor label Nov 26, 2024
@melvin-bot melvin-bot bot changed the title Report action says automatically approved $0.00 via [$250] Report action says automatically approved $0.00 via Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021861506983862256537

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@FitseTLT
Copy link
Contributor

FitseTLT commented Nov 28, 2024

@OfstadC Is there any specific way to reproduce it? when I submit the report from ND it properly shows the amount
image
but when I try to submit from OD it never auto approves even if I create an expense with lesser amount than the Approve manually above some amount setting of the workspace.
This part of the step is unclear

  1. Have a report submitted and approved on a OD

How do we submit in OD so that it will be auto approved?

Copy link

melvin-bot bot commented Dec 2, 2024

@OfstadC, @c3024 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@flaviadefaria flaviadefaria moved this to First Cohort - HIGH in [#whatsnext] #migrate Dec 2, 2024
@OfstadC
Copy link
Contributor

OfstadC commented Dec 2, 2024

How do we submit in OD so that it will be auto approved?

The workspace will need to have this set in Classic - Settings > Workspace > Members

https://help.expensify.com/articles/expensify-classic/reports/Require-review-for-over-limit-expenses

@FitseTLT
Copy link
Contributor

FitseTLT commented Dec 2, 2024

@OfstadC This one ?
image

I did set but when I submit the expense below that amount from ND it auto approves and the report action shows the amount properly and whenever I submit from OD it never auto-approves it requires a manual approval from the admin. It would be helpful if someone who can reproduce it record screenshots 👍

Copy link

melvin-bot bot commented Dec 3, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 4, 2024

@OfstadC, @c3024 Still overdue 6 days?! Let's take care of this!

@OfstadC
Copy link
Contributor

OfstadC commented Dec 4, 2024

whenever I submit from OD it never auto-approves it requires a manual approval from the admin.

Is the report you are testing under $200? I would set the randomly route reports to 0% as well.

@FitseTLT
Copy link
Contributor

FitseTLT commented Dec 4, 2024

whenever I submit from OD it never auto-approves it requires a manual approval from the admin.

Is the report you are testing under $200? I would set the randomly route reports to 0% as well.

Yes it is under that value and also I have tried to set it to 0% @OfstadC I think it would be better to have snapshots if you can reproduce it. Thx

@c3024
Copy link
Contributor

c3024 commented Dec 5, 2024

Waiting for proposals!

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
@c3024
Copy link
Contributor

c3024 commented Dec 10, 2024

Not overdue!

@melvin-bot melvin-bot bot removed the Overdue label Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 13, 2024

@OfstadC, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 13, 2024
@OfstadC
Copy link
Contributor

OfstadC commented Dec 13, 2024

Sorry @FitseTLT I haven't had a chance to get reproducible steps put together quite yet. I'll tackle this on Tuesday when i'm back in office. Hopefully sooner 🤞

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Dec 17, 2024

@OfstadC, @c3024 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Dec 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@OfstadC
Copy link
Contributor

OfstadC commented Dec 17, 2024

Hmmm... i'm not sure how to reproduce 🤔

All expenses/reports from Classic should still appear in NewDot, yeah?

I created an expense report in a test account and it was auto approved, but I don't see it in New Expensify 🤔

Copy link

melvin-bot bot commented Dec 19, 2024

@OfstadC, @c3024 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@OfstadC
Copy link
Contributor

OfstadC commented Dec 19, 2024

I still can't get new reports to reproduce. But all the already migrated reports are showing this 🤔

@c3024
Copy link
Contributor

c3024 commented Dec 20, 2024

Not overdue!

@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

Copy link

melvin-bot bot commented Dec 21, 2024

@OfstadC @c3024 this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@flaviadefaria
Copy link
Contributor

@OfstadC is this happening in the US policy? If so, it might be because we only half migrated this policy. So I'd suggest closing this and only re-opening if this persists after the whole policy has been migrated.

@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

@OfstadC, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 26, 2024

@OfstadC, @c3024 Eep! 4 days overdue now. Issues have feelings too...

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

Copy link

melvin-bot bot commented Dec 30, 2024

@OfstadC, @c3024 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

Copy link

melvin-bot bot commented Dec 31, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 1, 2025

@OfstadC, @c3024 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Jan 3, 2025

@OfstadC, @c3024 12 days overdue now... This issue's end is nigh!

@flaviadefaria
Copy link
Contributor

I'll close this since we now have fully migrated the US policy. @OfstadC please re-open if you run into this again.

@github-project-automation github-project-automation bot moved this from First Cohort - HIGH to Done in [#whatsnext] #migrate Jan 3, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
Development

No branches or pull requests

9 participants