BUG: Members showing as "Hidden" when invited to workspace chat

[jamesdeanexpensify]

Background

Coming from this conversation, there's at least one bug when a member invites other members to their workspace chat.

Details

• Expected outcome: When members are invited to a workspace chat, they should not show as Hidden in any case (whether they're on the same domain as the inviter or not).
• Actual outcome: I've seen a couple different cases as part of this thread:
  • Members of the same domain invited to a workspace chat show as Hidden. This happened to a Fullstory user. I'm not sure what I can share from the clip dude to sensitive customer info, but let me know what you need!
  • Members of a different domain invited to a workspace chat show as Hidden. @trjExpensify repro'd this:

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[greg-schroeder]

I think this is a Internal cause it's Auth

[melvin-bot]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Waiting for a volunteer

[arosiclair]

I'll take a look at this.

@jamesdeanexpensify do you have repro steps? It's not super clear if the hidden problem shows for the inviter/invitee. Also you should use the standard issue template to make these easier to pick up.

[jamesdeanexpensify]

Hey @arosiclair thanks for picking this up! I've only seen this happen from the inviter perspective, I haven't looked at the invitee perspective.

So I think the repro steps are:

1. Create a workspace
2. Go to the workspace chat
3. Click into the title of the workspace chat (where the dropdown arrow is), it should open the RHP
4. Click into Members
5. To test both ways: invite a member from the same domain, and then invite a member from a different domain
6. Look at the system messages that generate in the workspace chat
7. One or both system messages should say invited @Hidden in them

[arosiclair]

Okay I only see Hidden from the perspective of the member. Also I see that only the admin can invite users to a workspace chat. So repro steps are

1. Log in as a domain admin
2. Create a workspace
3. Invite a domain member
4. Open the workspace chat as both the admin and member in separate windows
5. As the admin, invite a domain member and non-domain members to the workspace chat

Result:

Member	Admin

After re-opening the chat as the member, the @mentions finally display properly.

[jamesdeanexpensify]

@arosiclair funny enough, I just saw this happen again from the admin perspective while reviewing a Fullstory session. What info do you need that would be most helpful?

[jamesdeanexpensify]

This scenario was (admin) [email protected] in their workspace chat Members pane inviting [email protected].

[arosiclair]

It looks like the root of the problem is that the user does not have personal details for the mentioned member so it displays as @hidden. We can start pushing personal details with @mentions, but I'm not sure that's always correct since not every user is "known" to each other. I'll see if we can just push public details to fix it instead.

[jamesdeanexpensify]

I think generally if you're typing in someone's email or phone number, you obviously know it and we could at least show that in the system message, right?

[arosiclair]

I think generally if you're typing in someone's email or phone number, you obviously know it and we could at least show that in the system message, right?

I'm talking about everyone in the room not just the person inviting.

[arosiclair]

I have a fix but it only works for existing users that have a display name. So if you invite a user that doesn't exist yet or a user that doesn't have a display name, it will still display a @hidden to the member. I'm looking into a better solution.

[arosiclair]

Alright I've got a better fix that should push personal details to everyone in private workspace rooms. Tagged Puneet on the PR to get a second look.

[greg-schroeder]

PR is up in draft form

[melvin-bot]

@arosiclair @greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[greg-schroeder]

Work on linked PR continues

[greg-schroeder]

Merged. Awaiting deploy to staging -> prod

[trjExpensify]

Just confirming this was the last PR for the issue? https://github.com/Expensify/Auth/pull/13345

[arosiclair]

Yeah it was this should be fixed now. Closing this out, but reopen in case something else is needed.