[HOLD for payment 2024-12-30] [$250] IOU - Workspace name is duplicate on report header for submitter

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5238580&group_by=cases:section_id&group_order=asc&group_id=309128
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

1. Login as the owner of the workspace
2. Create a workspace
3. Invite the approver and employee
4. Navigate to more features
5. Enable "workflows"
6. On the "Workflow" editor - enable "Add Approvals"
7. Set the Approver account as the Approver

Steps:

1. As employee submit 2 expenses in workspace chat
2. As approver open the report with 2 expenses
3. check the header to make sure it shows the Report ID, workspace and submitter.

4. As the submitter, notice the report ID and workspace name are shown twice.

Expected Result:

For the submitter, the report header should not include in %workspaceName% as it's repetitive. The workspace chat is the workspace name for them.

Actual Result:

For the submitter, we're repeating the workspace name.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-11-20_13-40-12.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021859415514696293689
• Upwork Job ID: 1859415514696293689
• Last Price Increase: 2024-11-21

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Christinadobrzyn]

Asking the team for some feedback. https://expensify.slack.com/archives/C05LX9D6E07/p1732081764396159

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021859415514696293689

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[rinej]

Hello, I am Tomek from callstack, I would like to work on that issue

[rinej]

I was able to reproduce it, I am working on the fix now

[Christinadobrzyn]

Awesome! Let me know if you want me to move this to weekly while you work on the PR @rinej!

[rinej]

In some cases the workspace chat and workspace itself was the same, I added the condition check to diplay the workspace only once in such case.

Here is the PR with the fix: #52914

And the video with the change:

ApproversTesting.mp4

[shawnborton]

Nice, that video looks pretty good to me

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Christinadobrzyn]

Sorry for all the labels, I'm trying add a new engineer to the issue for a review. But it looks like @jasperhuangg is not ooo so let me reach out to the team to find out what to do.

[Christinadobrzyn]

Thanks @mallenexpensify! We've moved this to daily to get this on @jasperhuangg K2 for reivew

[rinej]

Thanks @thesahindia and @Christinadobrzyn! The PR is merged :)

[Christinadobrzyn]

Awesome! monitoring PR #52914

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• IOU - Workspace name is duplicate on report header for submitter #52914

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @rinej does not require payment (Contractor)
• @thesahindia requires payment through NewDot Manual Requests

[melvin-bot]

@thesahindia @Christinadobrzyn @thesahindia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Christinadobrzyn]

Preparing for payment - @thesahindia do we need a regression test for this?

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @rinej is from an agency-contributor and not due payment
• Reviewer: @thesahindia owed $250 via NewDot

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1859415514696293689/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Payment day

• Contributor+: @thesahindia owed $250 via NewDot

@thesahindia do we need a regression test for this?

[melvin-bot]

@shawnborton, @rinej, @jasperhuangg, @Christinadobrzyn, @thesahindia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

Nudge @thesahindia do we need a regression test? Thanks!

[thesahindia]

Sorry for the delay!

The steps for the test case are below:-

For the submitter:

1. As user B, invite user A to your workspace
2. As user A, go to the newly invited workspace
3. Click on the "+" icon > Create expense
4. Enter the amount and submit
5. Click on the newly created expense
6. Verify that you don't see the workspace name twice in the header

For the approver:

1. As user B, open the workspace where user A submitted the expense
2. Click on the expense in the chat
3. Verify that the header shows the report ID, submitter and workspace

[Christinadobrzyn]

Thanks @thesahindia! Regression test here - https://github.com/Expensify/Expensify/issues/457359

Payment summary here - #52763 (comment)

Closing as complete! DMd @thesahindia to remind them to request payment through ND.