-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plan changes to Subscriptions #52588
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Still very excited for this one. |
Hoping to prioritize this week while things are quiet. |
Sweet - got a minute to work through some copy options for when the user is an admin on multiple workspaces here. |
Alright - OP is updated, now we're just waiting for the main issue to complete to open this one up. |
Quick clarification about the HOLD here:
|
@jayeshmangwani Hey Jayesh, here's another issue we need to work on to really complete the full upgrades/downgrades project. Seems like a natural progression for you to take over this issue too, let me know if there are any questions. I do have one question for you: we need to implement a check for whether the admin manages multiple workspaces or not. Do we have a way to check for that in the FE? Probably not, but thought I'd ask. If not, what kind of changes would you need from the BE (as in, what command or response would you like to see changed and how)? |
Yes, that sounds good. I will start working on this issue once we merge PR for the downgrade workspace UI and new downgrade API. @carlosmiceli @garrettmknight I will also need access to Figma, as I cannot find this section in the design doc. |
@carlosmiceli For the multiple workspaces admin front-end check, I think we already have a function that can be used here. Lines 391 to 393 in ec76adc
|
Boom! Looks like we're good here @garrettmknight 💪 |
Thanks 🙌 |
BE is merged 🙌 |
Small BE change requested by our contributors has both PRs in review, which should completely unblock @jayeshmangwani from completing the plan page work. |
Both BE PRs have been merged. |
Not Overdue, we will handle it after this PR |
@garrettmknight Whenever you get a chance, please help in get access to the Figma design/ Screenshots here |
Part of the Workspace Downgrades project
Main issue: https://github.com/Expensify/Expensify/issues/399936
Project: Workspace Downgrades
Feature Description
Your plan
section of the Subscriptions page to show both plan types with the current, highest plan type the account is an admin of highlighted/selected.Copy for options above in this Figma here
Manual Test Steps
Single Workspace Upgrade
Single Workspace Downgrade (follow Single Workspace Upgrade steps first)
Multi Workspace Upgrade (follow Single Workspace Upgrade + Downgrade steps first)
Multi Workspace Upgrade (follow Multi Workspace Upgrade steps first)
Automated Tests
N/A
The text was updated successfully, but these errors were encountered: