[HOLD for payment 2024-12-12] [$250] Report - Use + to submit expense is displayed instead of to create expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Click on FAB > Start chat > select a new user
2. Click + button

Expected Result:

The copy above the composer should say 'create' instead of 'submit' to reflect the change from submit expense to create expense in context menu

Actual Result:

The copy above the composer shows submit expense

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6662123_1731390014775.Screen_Recording_2024-11-12_at_8.31.06_in_the_morning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857384321549867205
• Upwork Job ID: 1857384321549867205
• Last Price Increase: 2024-11-15
• Automatic offers:
• daledah | Contributor | 105073749

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The copy above the composer shows submit expense

What is the root cause of that problem?

In here we always show submit in additionalText

App/src/components/ReportWelcomeText.tsx

Lines 48 to 54 in cd3f30f

	const filteredOptions = moneyRequestOptions.filter(
	(item): item is Exclude<IOUType, typeof CONST.IOU.TYPE.REQUEST | typeof CONST.IOU.TYPE.SEND | typeof CONST.IOU.TYPE.CREATE | typeof CONST.IOU.TYPE.INVOICE> =>
	item !== CONST.IOU.TYPE.INVOICE,
	);
	const additionalText = filteredOptions
	.map((item, index) => `${index === filteredOptions.length - 1 && index > 0 ? `${translate('common.or')} ` : ''}${translate(`reportActionsView.iouTypes.${item}`)}`)
	.join(', ');

What changes do you think we should make in order to solve the problem?

We should use canUseCombinedTrackSubmit to check when we show create and when we show submit like we did other places

    const additionalText = filteredOptions
        .map(
            (item, index) =>
                `${index === filteredOptions.length - 1 && index > 0 ? `${translate('common.or')} ` : ''}${translate(
                    canUseCombinedTrackSubmit && item === 'submit' ? `common.create` : `reportActionsView.iouTypes.${item}`,
                )}`,
        )
        .join(', ');

Note: we should create a new translation for create not capitalized

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857384321549867205

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[Anaslancer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Use + to submit expense is displayed instead of to create expense

What is the root cause of that problem?

We are getting CONST.IOU.TYPE.SUBMIT in getMoneyRequestOptions function.

What changes do you think we should make in order to solve the problem?

We should change CONST.IOU.TYPE.SUBMIT to CONST.IOU.TYPE.CREATE at here.
And add a new translation in reportActionsView.iouTypes at en.ts file and es.ts file.
create: 'create',
create: 'crear',

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Kalydosos]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The copy above the composer should say 'create' instead of 'submit' to reflect the change from submit expense to create expense in context menu

What is the root cause of that problem?

the change from submit to create has not been taking in account in the following lines

App/src/components/ReportWelcomeText.tsx

Lines 47 to 63 in cd3f30f

	const moneyRequestOptions = ReportUtils.temporary_getMoneyRequestOptions(report, policy, participantAccountIDs);
	const filteredOptions = moneyRequestOptions.filter(
	(item): item is Exclude<IOUType, typeof CONST.IOU.TYPE.REQUEST | typeof CONST.IOU.TYPE.SEND | typeof CONST.IOU.TYPE.CREATE | typeof CONST.IOU.TYPE.INVOICE> =>
	item !== CONST.IOU.TYPE.INVOICE,
	);
	const additionalText = filteredOptions
	.map((item, index) => `${index === filteredOptions.length - 1 && index > 0 ? `${translate('common.or')} ` : ''}${translate(`reportActionsView.iouTypes.${item}`)}`)
	.join(', ');
	const canEditPolicyDescription = ReportUtils.canEditPolicyDescription(policy);
	const reportName = ReportUtils.getReportName(report);
	const shouldShowUsePlusButtonText =
	(moneyRequestOptions.includes(CONST.IOU.TYPE.PAY) ||
	moneyRequestOptions.includes(CONST.IOU.TYPE.SUBMIT) ||
	moneyRequestOptions.includes(CONST.IOU.TYPE.TRACK) ||
	moneyRequestOptions.includes(CONST.IOU.TYPE.SPLIT)) &&
	!isPolicyExpenseChat;

What changes do you think we should make in order to solve the problem?

As this change occurs locally and in the context of smoothly transitioning from oldDot, we should apply the change locally and avoid changing functions shared by other codes, thus we can just replace submit by create in the money request options, filter in create for the text to display and create translations in reportActionsView.iouTypes for the action create. This changes the lines above into

the translations are

en.ts

es.ts

RESULT

it works fine with few local changes

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

@sonialiap, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sonialiap]

@rushatgabhane what do you think of the above proposal?

[melvin-bot]

@sonialiap, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this?

[daledah]

@rushatgabhane please take a look when you get a chance

[rushatgabhane]

@daledah's proposal LGTM 🎀 👀 🎀

#52393 (comment)

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@sonialiap @rushatgabhane @techievivek this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.71-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: use display create instead of submit expense #53159

If no regressions arise, payment will be issued on 2024-12-12. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@rushatgabhane @sonialiap @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sonialiap]

Payment summary:

• @rushatgabhane $250 via ND - please complete the checklist
• @daledah no profile found

[garrettmknight]

$250 approved for @rushatgabhane

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sonialiap]

I'm OOO Dec 16-20, adding a leave buddy

next steps:

• @rushatgabhane complete the checklist
• add regression test if applicable

[abekkala]

@daledah OFFER

[abekkala]

PAYMENT SUMMARY FOR DEC 12

• @rushatgabhane [$250] via ND - please complete Checklist
• @daledah [$250] OFFER

[melvin-bot]

@abekkala, @sonialiap, @rushatgabhane, @techievivek, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

@daledah payment sent and contract ended - thank you! 🎉