[HOLD for payment 2024-11-14] [Workspace feeds] Formatting/styling of assigned card on Wallet page is odd

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): quality

Action Performed:

Prerequisite:
Members and company cards added in workspace.

1. Go to staging.new.expensify.com
2. Choose the workspace from settings
3. Assign card to a member
4. Go to wallet > assign cards

Expected Result:

Format and styling should be as per the design doc

Actual Result:

Formatting/styling of assigned card on Wallet page is odd

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @AndrewGable (AutoAssignerNewDotQuality)

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

[mountiny]

Handling this as part of the project I have worked on

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

Should be fixed in this PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Custom feeds] Clean up for the wallet and workspace member page #51671

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @dukenv0307 requires payment (Needs manual offer from BZ)

[melvin-bot]

@dukenv0307 @adelekennedy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• ROLE: @dukenv0307 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[adelekennedy]

So sorry about this! This slipped off my radar last week, reviewing the PR I think @dukenv0307 is the only one due payment here - @mountiny are there any different payment terms for the project or is this the $250 standard?

[dukenv0307]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This is the new feature, so no need to add offending PR

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Log in as a user with several Expensify and Company cards.
2. Go to the Wallet page.
3. Make sure card icons and names are displayed as expected.
4. Go to the Workspace where the current user has Expensify and Company cards.
5. Go to Members and open the current user member page.
6. Make sure company card icons have a normal size.

Do we agree 👍 or 👎

[adelekennedy]

Payouts due:

• Contributor: $250 @dukenv0307 NewDot

[mountiny]

@dukenv0307 Noting that we will handle the payments all in one go for the project

[dukenv0307]

@mountiny Yes, I know. I mentioned that in other issues too