Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-20] [Workspace Feeds] Export Row Not Updating on Card Details Page After Selection #51880

Closed
1 of 8 tasks
m-natarajan opened this issue Nov 1, 2024 · 13 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #quality

Action Performed:

Prerequisite:
Members and company cards added in workspace

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card details
  4. Click Quickbooks Online Credit card export > Expensify card liability account

Expected Result:

Selected option updated in export row

Actual Result:

Selected option not updated in export row

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
2024-10-31_13-28-05.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added Weekly KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 1, 2024
@m-natarajan m-natarajan added Weekly KSv2 and removed Daily KSv2 labels Nov 1, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@m-natarajan
Copy link
Author

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

@m-natarajan m-natarajan added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

@mountiny mountiny changed the title Export Row Not Updating on Card Details Page After Selection [Workspace Feed] Export Row Not Updating on Card Details Page After Selection Nov 1, 2024
@narefyev91
Copy link
Contributor

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

@mountiny mountiny changed the title [Workspace Feed] Export Row Not Updating on Card Details Page After Selection [Workspace Feeds] Export Row Not Updating on Card Details Page After Selection Nov 4, 2024
@mountiny
Copy link
Contributor

mountiny commented Nov 4, 2024

Added to the project

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 7, 2024
@stephanieelliott
Copy link
Contributor

PR was deployed to prod on 11/13

@stephanieelliott stephanieelliott changed the title [Workspace Feeds] Export Row Not Updating on Card Details Page After Selection [HOLD for payment 2024-11-20] [Workspace Feeds] Export Row Not Updating on Card Details Page After Selection Nov 19, 2024
@stephanieelliott stephanieelliott added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Nov 19, 2024
@allgandalf
Copy link
Contributor

No payment here @stephanieelliott , it is part of project, I will update the checklist tomorrow and then we can close

@DylanDylann
Copy link
Contributor

@allgandalf I already reviewed the PR, let me post checklist

@DylanDylann
Copy link
Contributor

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: I think we don't need to comment on the previous PR because @narefyev91 also be author of this feature

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion:

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Prerequisite

Members and company cards added in workspace

Test:

  1. Choose the workspace from settings
  2. Click company cards >Card details
  3. Click Quickbooks Online Credit card export
  4. Select an option and verify that the new value is updated

Do we agree 👍 or 👎

@DylanDylann
Copy link
Contributor

@stephanieelliott Could you help to assign me to this issue? because I already reviewed the PR

Copy link

melvin-bot bot commented Nov 20, 2024

Payment Summary

Upwork Job

  • Contributor: @narefyev91 is from an agency-contributor and not due payment
  • ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@stephanieelliott)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@mountiny mountiny assigned DylanDylann and unassigned allgandalf Nov 20, 2024
@mountiny
Copy link
Contributor

Checklist is done and we will add the regression tests with Jow as part of the project so I think we can close this as payments will be done separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2
Development

No branches or pull requests

7 participants