[HOLD for payment 2024-11-20] [$250] Expense-"Hidden" appears in Members list when the workspace is created via Pay with Expensify

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5134693
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Default individual policy currency for both users must be USD.

1. Go to staging.new.expensify.com
2. [User A] Submit an expense in USD to User B
3. [User B] Go to DM with user A
   4/ [User B] Click Pay with Expensify
4. [User B] Click Business bank account
5. [User B] Close the RHP
6. [User B] Go to workspace settings of the newly created workspace
7. [User B] Go to Members

Expected Result:

There will be no "Hidden" member

Actual Result:

"Hidden" member appears in Members list when the workspace is created via Pay with Expensify in p2p expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6645865_1729878847118.20241026_014655.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021853396876299534935
• Upwork Job ID: 1853396876299534935
• Last Price Increase: 2024-11-04

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hidden is shown in the workspace member after moving the expense to a new workspace.

What is the root cause of that problem?

When we select Business bank account as the payment method, we will optimistically create a new workspace based on the IOU report data.

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 110 to 111 in 652d2ff

	if (iouReport && ReportUtils.isIOUReport(iouReport)) {
	const {policyID, workspaceChatReportID, reportPreviewReportActionID} = Policy.createWorkspaceFromIOUPayment(iouReport) ?? {};

The problem is, we are trying to create the workspace member from the IOU report ownerEmail.

App/src/libs/actions/Policy/Policy.ts

Line 2134 in 652d2ff

const employeeEmail = iouReport.ownerEmail ?? '';

App/src/libs/actions/Policy/Policy.ts

Lines 2184 to 2191 in 652d2ff

	[sessionEmail]: {
	role: CONST.POLICY.ROLE.ADMIN,
	errors: {},
	},
	[employeeEmail]: {
	role: CONST.POLICY.ROLE.USER,
	errors: {},
	},

However, ownerEmail doesn't exist anymore in the IOU report, only ownerAccountID, so it defaults to an empty string.

What changes do you think we should make in order to solve the problem?

There was previously a plan to get the employee email from the personal detail, but I decided to just default it to an empty string because, at that time, the email wasn't really needed.

Previously, the policy member is keyed by their accountID.

So, the solution is to get the employee's email from the personal details data.

const employeeEmail = allPersonalDetails?.[employeeAccountID]?.login ?? '';

I don't think the personal detail login would be undefined, but we can avoid creating the employee optimistic data if employeeEmail is empty.

[zanyrenney]

Wave collect is closed, but adding this to expense.

[melvin-bot]

@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[zanyrenney]

Oops, i thought I added the external label here - my bad!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021853396876299534935

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

on my list this week

[hungvu193]

@bernhardoj How do you reproduce this issue?

[bernhardoj]

I just followed the OP steps and remove the currency check here so I can choose Pay with Expensfiy even without USD currency.

App/src/components/SettlementButton/index.tsx

Line 101 in afa7b33

const canUseWallet = !isExpenseReport && !isInvoiceReport && currency === CONST.CURRENCY.USD;

[hungvu193]

I did the same thing but it navigates to Connect Bank Account flow page instead 🤔

Screen.Recording.2024-11-07.at.13.30.37.mov

[bernhardoj]

Hmm, that's weird. It should show a popover menu first to choose between business or personal bank account. From the code, you need to satisfy the condition to trigger triggerKYCFlow,

App/src/components/SettlementButton/index.tsx

Lines 186 to 201 in afa7b33

	const selectPaymentType = (event: KYCFlowEvent, iouPaymentType: PaymentMethodType, triggerKYCFlow: TriggerKYCFlow) => {
	if (policy && SubscriptionUtils.shouldRestrictUserBillableActions(policy.id)) {
	Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(policy.id));
	return;
	}
	if (iouPaymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY || iouPaymentType === CONST.IOU.PAYMENT_TYPE.VBBA) {
	if (!isUserValidated) {
	Navigation.navigate(ROUTES.SETTINGS_WALLET_VERIFY_ACCOUNT.route);
	return;
	}
	triggerKYCFlow(event, iouPaymentType);
	BankAccounts.setPersonalBankAccountContinueKYCOnSuccess(ROUTES.ENABLE_PAYMENTS);
	return;
	}

and this, inside triggerKYCFlow.

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 156 to 175 in afa7b33

	// Check to see if user has a valid payment method on file and display the add payment popover if they don't
	if (
	(isExpenseReport && reimbursementAccount?.achData?.state !== CONST.BANK_ACCOUNT.STATE.OPEN) ||
	(!isExpenseReport && bankAccountList !== null && !PaymentUtils.hasExpensifyPaymentMethod(paymentCardList, bankAccountList, shouldIncludeDebitCard))
	) {
	Log.info('[KYC Wallet] User does not have valid payment method');
	if (!shouldIncludeDebitCard) {
	selectPaymentMethod(CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT);
	return;
	}
	const clickedElementLocation = getClickedTargetLocation(targetElement as HTMLDivElement);
	const position = getAnchorPosition(clickedElementLocation);
	setPositionAddPaymentMenu(position);
	setShouldShowAddPaymentMenu(true);
	return;
	}

[hungvu193]

Nevermind, I can reproduce it with my brand new account 🤦

[bernhardoj]

PR is ready

cc: @hungvu193

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix hidden members is shown when creating workspace from iou payment #52296

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment through NewDot Manual Requests
• @bernhardoj requires payment through NewDot Manual Requests

[melvin-bot]

@hungvu193 @zanyrenney @hungvu193 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[hungvu193]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: We removed ownerEmail from IOU report. However we forgot to update it while selecting Business Bank Account

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/39489/files#r1849609429

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not a critical bug, we don't need to create a discussion.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

1. User B requests money to User A in USD
2. User A press Pay with Expensify and choose Business Bank Account. Note down the new workspace created
3. Go to the workspace member page of the newly created workspace
4. Verify there is no Hidden member

Do we 👍 or 👎 ?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @hungvu193 owed $250 via NewDot
• Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@zanyrenney)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1853396876299534935/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[bernhardoj]

Requested in ND.

[garrettmknight]

@zanyrenney can you confirm the payment summary when you get a chance?

[zanyrenney]

sure thing @garrettmknight - sorry about the delay everyone. I was out yesterday.

[zanyrenney]

Regression test looks good - getting that added now.

[zanyrenney]

https://github.com/Expensify/Expensify/issues/446583

[zanyrenney]

Closed job on upwork.

Payment Summary

Reviewer: @hungvu193 owed $250 via NewDot - please request via ND
Reviewer: @bernhardoj owed $250 via NewDot - please request via ND

[JmillsExpensify]

$250 approved for @bernhardoj

[garrettmknight]

$250 approved for @hungvu193