[HOLD for payment 2024-12-12] [$250] Web - [AU] Attachment - Console errors appear when uploading a PDF attachment to a 1:1 DM

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:* https://expensify.testrail.io/index.php?/tests/view/5120680&group_by=cases:section_id&group_id=292107&group_order=asc
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/ and open Safari console
2. Log in with a Gmail account
3. Open any 1:1 DM
4. Navigate to + button - Add attachment
5. Send any PDF attachment

Expected Result:

There shouldn't be any console errors.

Actual Result:

Console errors appear when uploading a PDF attachment to a 1:1 DM.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2310.txt

Bug6642816_1729659401969.Screen_Recording_2024-10-22_At_21.39.25.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851679624000395857
• Upwork Job ID: 1851679624000395857
• Last Price Increase: 2024-11-20

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

@abekkala Eep! 4 days overdue now. Issues have feelings too...

[abekkala]

I was able to reproduce in Safari

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851679624000395857

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

@abekkala, @aimane-chnaif Huh... This is 4 days overdue. Who can take care of this?

[aimane-chnaif]

No proposals yet

[aimane-chnaif]

I am out sick at the moment. Please reassign C+ if needed

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

Updates as for today:

• I was able to reproduce the issue in the Safari browser. For me this issue is also partly reproducible if I attach a pdf file as a receipt (by partly I mean that I see only part of the error logs)
• First part of the console errors disappears if I change the pdfWorkerSource import to be imported not from pdfjs-dist/legacy/build/pdf.worker.mjs, but from pdfjs-dist/build/pdf.worker.mjs in the PDFThumbnail component and PDFPreviewer component (from react-fast-pdf)

I'll continue my investigations tomorrow

[VickyStash]

Updates:
I was able to identify the place which triggers the second part of the errors.
The problem is in the attachment optimistic report action, specifically in the attachment source attribute which is passed in the data attributes to the pdf attachment:

App/src/libs/ReportUtils.ts

Line 4307 in 346bb37

`${CONST.ATTACHMENT_SOURCE_ATTRIBUTE}="${file.uri}"`,

And the way it's used for the report action display.
I still need to find the way to handle it without errors, I haven't had enough time for it today unfortunately.
After that I should be able to combine formal proposal.

[melvin-bot]

@abekkala Huh... This is 4 days overdue. Who can take care of this?

[allgandalf]

Not overdue sir melv 🙇

[VickyStash]

Updates:
I've prepared the app PR as well. Note: it uses the patch for react-fast-pdf. We can easily remove it when Expensify/react-fast-pdf#39 is merged. Let's focus maybe on merging the lib PR first.

[allgandalf]

@tylerkaraszewski can you please approve and merge the upstream PR:

• Update pdfWorkerSource to fix console warnings react-fast-pdf#39

[VickyStash]

@tylerkaraszewski kind bump, could you take a look at the PR: Expensify/react-fast-pdf#39

[allgandalf]

Bumped on slack for 👀

[allgandalf]

2nd PR is on staging:

• Fix console errors during PDF attachment preview #53080

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.71-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix console errors during PDF attachment preview #53080

If no regressions arise, payment will be issued on 2024-12-12. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @abekkala @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[abekkala]

PAYMENT SUMMARY FOR DEC 12

• Fix: @VickyStash - no payment needed
• PR Review: @allgandalf [$250] Offer
  Please complete checklist

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1851679624000395857/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: chore: fix security vulnerabilities #48532 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• N/A

Test:

1. Open any chat.
2. Start to add a PDF attachment.

Verify that during the PDF attachment preview before sending the attachment there are no console errors.

Do we agree 👍 or 👎

[abekkala]

@allgandalf payment sent and contract ended - thank you! 🎉