Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow QA to test the Fullstory integration in staging #51211

Closed
3 of 4 tasks
anmurali opened this issue Oct 22, 2024 · 20 comments
Closed
3 of 4 tasks

Allow QA to test the Fullstory integration in staging #51211

anmurali opened this issue Oct 22, 2024 · 20 comments
Assignees
Labels

Comments

@anmurali
Copy link

anmurali commented Oct 22, 2024

Problem: Our FullStory integration is quickly becoming a critical part of New Expensify. If it breaks than we are left blind without the ability to debug issues for users and determine the usability of New Expensify.

Solution: Add a FullStory test case for Applause to test on each staging build to verify that we haven’t added any regressions to the integration. We need to be able to record sessions for specific accounts on staging, but keep the integration turned off for staging to not hit our session limit.

  • Identify a specific domain like @fstest.expensify.com that we can use specifically for this purpose
  • When this email user is detected in staging, start the Fullstory session. Do not record any other staging sessions for any other domains
  • Write down regression tests that utilize this domain for making sure the Fullstory session works as designed
  • Train Applause on testing this
Issue OwnerCurrent Issue Owner: @anmurali
@anmurali
Copy link
Author

cc @danieldoglas @AndrewGable

Copy link

melvin-bot bot commented Oct 25, 2024

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@anmurali
Copy link
Author

@danieldoglas I was wondering if this is all simple as adding a user email check to the same place where we make sure to only start a FS session if the environment is production?

@melvin-bot melvin-bot bot removed the Overdue label Oct 29, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@anmurali
Copy link
Author

anmurali commented Nov 5, 2024

Discussed a solution here
@danieldoglas can I assign this to you?

@melvin-bot melvin-bot bot removed the Overdue label Nov 5, 2024
@danieldoglas danieldoglas self-assigned this Nov 5, 2024
@danieldoglas
Copy link
Contributor

awaiting the decision about the email.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Nov 5, 2024
@melvin-bot melvin-bot bot changed the title Allow QA to test the Fullstory integration in staging [HOLD for payment 2024-11-14] Allow QA to test the Fullstory integration in staging Nov 7, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 7, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-14. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

@danieldoglas Eep! 4 days overdue now. Issues have feelings too...

@danieldoglas
Copy link
Contributor

There's no payment on this one.

@danieldoglas
Copy link
Contributor

assigning @anmurali so she can work on writing the tests we want here.

@melvin-bot melvin-bot bot added the Overdue label Nov 22, 2024
@danieldoglas danieldoglas changed the title [HOLD for payment 2024-11-14] Allow QA to test the Fullstory integration in staging Allow QA to test the Fullstory integration in staging Nov 22, 2024
@danieldoglas danieldoglas removed the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 22, 2024
@danieldoglas
Copy link
Contributor

WIP

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 22, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

@danieldoglas, @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Nov 28, 2024

@danieldoglas, @anmurali Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 2, 2024

@danieldoglas, @anmurali 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Dec 4, 2024

@danieldoglas, @anmurali 10 days overdue. I'm getting more depressed than Marvin.

@danieldoglas danieldoglas added Weekly KSv2 and removed Daily KSv2 labels Dec 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2024
@anmurali
Copy link
Author

anmurali commented Dec 5, 2024

Regression test proposal

  1. Sign up on www.expensify.com and select Organize my own expenses or Manage expenses for a small team (1-9 employees) with an email like [email protected]
  2. Select anything from What do you want to do today or Do you use any accounting software? as the case may be
  3. Login to app.fullstory.com
  4. Go to Home - Just watch sessions
  5. Under "User Filters" -- In the Any user dropdown, select email and enter the email used for sign up
  6. Scroll down and verify that a session is found under Session Playlist
  7. In Session Playlist click on the email, scroll down and verify that user properties are populated
image

Repeat the above steps by signing up on new.expensify.com

Repeat the above steps by signing in with a previously signed up [email protected] on www.expensify.com, new.expensify.com). For sign in, verify the additional step below as well:
8. Verify by watching the most recent session in the Session Playlist by clicking on the green play button, that the actions on sign in are in fact recorded.

Repeat the above steps including step 8 with a previously signed up (and redirected to new dot) [email protected] on hybrid app (iOS and Android)

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
@anmurali
Copy link
Author

This is all setup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants