Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-20] [GR Phase 2] Step 3 Business info screen (without save API call) #50899

Closed
madmax330 opened this issue Oct 16, 2024 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2

Comments

@madmax330
Copy link
Contributor

Design doc section: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.xfavl5zeoc0f

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Oct 24, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Oct 29, 2024

Update on my end. For now I've created draft PR. I'm expecting to create proper PR tomorrow. There might be some conflicts appearing soon. Apart from that I need to rebase it, test on all platforms and gather recordings.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Oct 30, 2024

Taking longer than expected due to complex situation with forms and various selectors. I've simplified logic of our brand new component that we added in previous PR (PushRowWithModal) and replaced usage of StateSelector.

State/Country selectors need to be looked at as a lot of it can be simplified. We have a few components that do the same thing in different ways. I will try have a look at it after we're done with this feature.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Oct 31, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 13, 2024
@melvin-bot melvin-bot bot changed the title [GR Phase 2] Step 3 Business info screen (without save API call) [HOLD for payment 2024-11-20] [GR Phase 2] Step 3 Business info screen (without save API call) Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 13, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests
  • @MrMuzyk does not require payment (Contractor)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 19, 2024
Copy link

melvin-bot bot commented Nov 20, 2024

Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Nov 20, 2024

Payment Summary

Upwork Job

  • Reviewer: @hungvu193 owed $250 via NewDot
  • Contributor: @MrMuzyk is from an agency-contributor and not due payment

BugZero Checklist (@trjExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@trjExpensify
Copy link
Contributor

Confirming payments as follows:

Not moving forward with a regression test, as this is part of the global reimbursement project. When built overall, the project team should take care of handing over the suite of regression tests to Applause.

Closing!

@garrettmknight
Copy link
Contributor

$250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants