[Workspace Chats for All] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat

[puneetlath]

Problem

There are a few different ways users can end up in a scenario in NewDot where they aren't able to submit expenses to their workspace. A couple known scenarios:

1. The user is on an existing policy that gets added to the policyExpenseChat beta. When someone is added to this beta, we don't create workspace chats for users immediately. We do create the workspace chat the next time an expense/report is created, but that can only be done via OldDot since there is no workspace chat in NewDot and the only way to submit an expense in NewDot is to submit it to the workspace chat. This scenario will soon apply to all of our internal policies, which we plan to update to be NewDot-enabled imminently.
2. When a user is on an existing policy that isn't on the policyExpenseChat beta. This can happen when a user lands in NewDot (for example to chat with Concierge) and tries it out. We've seen multiple examples of this happening with existing users in #concierge-development

Solution

Update NewDot to allow submitting to any policy you are a member of, whether or not a workspace chat exists for it. The back-end will then handle creating a workspace chat for the expense if necessary. This would solve the problem for both 1 and 2.

To do this we will:

1. Show all workspaces the user is a member of that have isPolicyExpenseChatEnabled=true in the submit expense dialog, whether or not workspace chats exist for them
2. Pass both a policyID and workspace chat reportID when creating the expense
3. If the user doesn't have a workspace chat locally, then we will create an optimistic one
4. The back-end will handle taking the optimistic workspace chat report and creating it if necessary
5. If a workspace chat already exists that is different than the optimistic one, we will return the pre-existing reportID (just like we do when starting chats)

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[puneetlath]

@dubielzyk-expensify un-assigning you since there's no new UI being added here.

[ishpaul777]

not overdue

[ishpaul777]

@puneetlath please make melvin happy : ) sorry i didn't relize i can also do that

[flaviadefaria]

Moving this over to #migrate project as it will be a blocker for enabling workspace chat for existing workspaces of Cohort 1.

[JmillsExpensify]

Can we move this issue to Daily given that it's CRITICAL for #migrate?

[ishpaul777]

we are making daily progress on this, Draft Pr (almost ready) here: #49412 @puneetlath is working on BE changes

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @ishpaul777] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[puneetlath]

Back-end PR for requestDistance is here: https://github.com/Expensify/Web-Expensify/pull/44129

Once that is on staging, we should be able to proceed with the reverted front-end PR.

[puneetlath]

Likely going to change this behavior based on this discussion: https://expensify.slack.com/archives/C07NMDKEFMH/p1730152377459179?thread_ts=1730145327.196299&cid=C07NMDKEFMH

I'll update here shortly.

[puneetlath]

Ok, I've already talked to @ishpaul777 but after a lot of discussion in #migrate we have decided we are going to pause this work and instead go in a different direction. We're going to do #51804 instead for now.

[ishpaul777]

Is this on HOLD or should be closed now that we go in a different direction ??

[melvin-bot]

@puneetlath, @allroundexperts, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

[puneetlath]

We should close it. Just need to pay out for the work done.

[ishpaul777]

@puneetlath lets wrap this up ? : )

to summarize:

There was 3 PRs:

1. [Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #49412 merged but we had to revert becuase of a unhandled Distance flow
2. [FIX] Category list loads infinitely when submitting to non-existing workspace chat #51243 Bug fixes for ^ but we didn't merge becuase above was reverted
3. [Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat #51341 redo of 1 with all bugs fixed but closed because we decided to not pursue this issue but the work was completed

[melvin-bot]

@puneetlath, @allroundexperts, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

[puneetlath]

Payment summary:

• C - @ishpaul777 - $750 for 3 PRs
• C+ - @allroundexperts - $500 for 2 PRs

@ishpaul777 offer is here: https://www.upwork.com/nx/wm/offer/104882055. Please ping me on this issue when you've accepted.

@allroundexperts please request in NewDot.

[ishpaul777]

Accepted the offer! Thanks!

[puneetlath]

Paid. Thanks y'all!