[Native Share] Implement Native Share for Android

[grgia]

Description

This is a tracking issue for the Android implementation of the Native Share project. This section of the project will be handled separately but merged alongside the IOS issue.

Project

https://docs.google.com/document/d/14C1VifxvIXeyLAf0XstbC-wvyAb5SQZ0AOw0-jLRyZs/edit

Tracking

#36613

Issue Owner

Current Issue Owner: @filip-solecki

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[BrtqKr]

Hey, I'm from SWM, I'd like to take care of this issue.

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[JmillsExpensify]

Going through the process.

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr 10 days overdue. I'm getting more depressed than Marvin.

[grgia]

Bumped for update / steps for unblocking permissions

[BrtqKr]

I am focusing on split navigation atm. I'll try to complete the flow whenever I'm done with the nav.

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[BrtqKr]

We've split the work with @filip-solecki and he's taking care of the android atm. We're implementing both platforms in parallel

[filip-solecki]

Hi! Yes, I am working on this issue right now

[grgia]

Thanks @filip-solecki and @BrtqKr !

[grgia]

Hey, @filip-solecki, do you have a draft PR up for this?

[filip-solecki]

Yes, it was created a long time ago. I've updated it and working on it! Here it is

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

@filip-solecki mind posting a quick update here as well?

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[filip-solecki]

Hi! @Guccio163 is currently working on the shared file preview and remaining JS-related issues, while I am working on adding support for text sharing.

[melvin-bot]

@JmillsExpensify, @grgia, @BrtqKr, @filip-solecki Eep! 4 days overdue now. Issues have feelings too...

[grgia]

@filip-solecki could you give me an update on when you think we could get a draft PR up for android as well?

[filip-solecki]

Hi! Same as for iOS as this will be one PR for both platforms

[Guccio163]

Hi @grgia, how do you think we should implement attachment preview section (visible with the donut below) - should it always crop to the predefined dimensions, or maybe scale to fit the whole attachment? It's quite different from Submit flow, because we have to count pdf and videos in, which display in different dynamics than Image in AttachmentView (pdfs can be scrolled and always scale to full width, videos can't be cropped).

[grgia]

@Expensify/design could you help out with this question

[dannymcclain]

Is it possible to open the attachment modal from this share screen? Like if I tap on that donut image, do I get the attachment modal showing the whole image?

[grgia]

@Guccio163 @filip-solecki could you send an update on this? Also did you get a chance to check out this comment

[filip-solecki]

Sure, Android part is done, right now we are working on polishes for iOS as it will be included in one PR

[filip-solecki]

Is it possible to open the attachment modal from this share screen? Like if I tap on that donut image, do I get the attachment modal showing the whole image?

Sure it is

[shawnborton]

If you can open up the whole attachment in a preview modal, then maybe the easiest thing to do is reuse the attachment box we have when you go to submit an expense?

[Guccio163]

I'll look closely into it, but from what I've checked it's not that straightforward, because Submit allows only images and right now the biggest problem is making it unified for images, pdfs and videos. Because we are thinking about allowing user to open fullscreen AttachmentView after clicking on the miniature, last friday I came up with an idea to not use rescaled AttachmentView in a thumbnail (which is tricky), but rather try to scale thumbnails used in chats for these types of media.

WDYT @shawnborton ?

[shawnborton]

but rather try to scale thumbnails used in chats for these types of media.

That works for me, I agree we need to support multiple media formats here on the share page so however you think is best to accomplish that works for me.

[dannymcclain]

Yup that works for me too! That's kinda where I was going when I asked about the attachment modal. I think since you can "open" the attachment, it's much less important how we display the thumbnail.

however you think is best to accomplish that works for me

Agree with this ☝️

[Guccio163]

Hi, I'm coming with an update on this issue!

We are successfully displaying thumbnails for Images and Videos, though I'm not sure if we should align them to center of left, what do you think?

Also, we're using DefaultAttachmentView for any file other than image and video:

That leaves us with PDFs: When PDF thumbnails are being displayed f.ex. in chats, they use .jpg thumbnail images generated specifically on backend. When using share-extension, whole data is sourced from files locally on device, so the only way to properly show PDFs thumbnail is to:

1. extract first page of the file on device (platform specific)
2. convert it into .jpg file
   3 a. save file and send it's localisation
   or
   3 b. send file as a blob

Both ways are potentially time consuming, so right now @filip-solecki and I propose to use DefaultAttachmentView for PDF just like for all other files and after user clicks on it, show the file in AttachmentModal (or not). That of course is available, because AttachmentModal uses whole files to display them, but could be misleading to users that some files shown as DefaultAttachmentView are able to be viewed in modal and some aren't.

Let me know what you think; We still have to fix a couple of new cases introduced in share-extension, but I feel we are really close to creating the draft soon 👌

[shawnborton]

I think left-aligned makes the most sense, cc @Expensify/design for thoughts though!

[dannymcclain]

I'm down with left-aligned.

And re: PDFs, I think it's fine to display them using the "other file" preview style.

could be misleading to users that some files shown as DefaultAttachmentView are able to be viewed in modal and some aren't

While this is totally true, I personally don't think it's a huge deal. I don't think clicking on a PDF or text file to look at it is going to be common here, so I personally don't think it will lead to much, if any, confusion. If we're REALLY concerned about it, I even think it would be ok to just disable the AttachmentModal for PDFs in this situation. Just my 2 cents!

[dubielzyk-expensify]

Left aligned works for me too 👍