Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOLD #48400 [$250] Red dot (RBR) doesn't go away even though this split expense has been paid/settled ("paid elsewhere") by all parties #48423

Open
1 of 6 tasks
m-natarajan opened this issue Sep 2, 2024 · 40 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Sep 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724971827199829

Action Performed:

  1. Create a split expense in a group chat
  2. Settle the expense (Paid elsewhere) by all the members the expense was split

Expected Result:

No RBR in LHN

Actual Result:

RBR displayed in LHN and unable to dismiss it.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

image

Onyx Data:

{
    "chatType": "group",
    "lastActorAccountID": "1520269",
    "lastMessageText": "Yup",
    "lastVisibleActionCreated": "2024-08-28 18:45:43.504",
    "ownerAccountID": 0,
    "participants": {
        "1381556": {
            "hidden": false,
            "notificationPreference": "always",
            "role": "member"
        },
        "1520269": {
            "hidden": false,
            "notificationPreference": "always",
            "role": "member"
        },
        "4037741": {
            "hidden": false,
            "notificationPreference": "always",
            "role": "admin"
        }
    },
    "policyID": "_FAKE_",
    "reportID": "4421636436784885",
    "reportName": "",
    "stateNum": 0,
    "statusNum": 0,
    "type": "chat",
    "isEdited": true,
    "lastMessageHtml": "Yup",
    "currency": "USD",
    "description": "",
    "errorFields": {},
    "hasOutstandingChildRequest": false,
    "hasOutstandingChildTask": false,
    "isCancelledIOU": false,
    "isOwnPolicyExpenseChat": false,
    "isPinned": true,
    "isWaitingOnBankAccount": false,
    "lastActionType": "ADDCOMMENT",
    "lastReadSequenceNumber": 0,
    "lastReadTime": "2024-08-28 18:45:43.504",
    "lastVisibleActionLastModified": "2024-08-28 18:45:43.504",
    "nonReimbursableTotal": 0,
    "notificationPreference": "always",
    "oldPolicyName": "",
    "permissions": [
        "read",
        "write",
        "share"
    ],
    "private_isArchived": "",
    "total": 0,
    "unheldTotal": 0,
    "welcomeMessage": "",
    "writeCapability": "all",
    "lastMessageTranslationKey": "",
    "maxSequenceNumber": 0,
    "isLoadingPrivateNotes": false,
    "privateNotes": {
        "1520269": {
            "note": ""
        }
    },
    "managerID": 0
}

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021833077301118863367
  • Upwork Job ID: 1833077301118863367
  • Last Price Increase: 2025-01-06
Issue OwnerCurrent Issue Owner: @ikevin127
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 2, 2024
Copy link

melvin-bot bot commented Sep 2, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@muttmuure
Copy link
Contributor

tomorrow

@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2024
@muttmuure muttmuure added the External Added to denote the issue can be worked on by a contributor label Sep 9, 2024
@melvin-bot melvin-bot bot changed the title Red dot (RBR) doesn't go away even though this split expense has been paid/settled ("paid elsewhere") by all parties [$250] Red dot (RBR) doesn't go away even though this split expense has been paid/settled ("paid elsewhere") by all parties Sep 9, 2024
Copy link

melvin-bot bot commented Sep 9, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021833077301118863367

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 9, 2024
Copy link

melvin-bot bot commented Sep 9, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@muttmuure
Copy link
Contributor

I think it's likely this needs to go into #newdot-quality.

@Vicolas11
Copy link

Hello, has this issue been assigned to any Upwork freelancer?

Copy link

melvin-bot bot commented Sep 9, 2024

📣 @Vicolas11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@ikevin127
Copy link
Contributor

Hello, has this issue been assigned to any Upwork freelancer?

Not yet, looking for proposals (if the issue is reproducible).

Copy link

melvin-bot bot commented Sep 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
Copy link

melvin-bot bot commented Sep 16, 2024

@muttmuure @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Sep 16, 2024

@muttmuure, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?

@ikevin127

This comment was marked as outdated.

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

@muttmuure, @ikevin127 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Sep 23, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Oct 14, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Oct 21, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@ikevin127
Copy link
Contributor

Not overdue, on hold.

@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2024
Copy link

melvin-bot bot commented Oct 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Nov 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@ikevin127
Copy link
Contributor

Coming from the HOLD issue #48400 (comment):

From this #48400 (comment), seems part of the behavior is expected. Closing it out for now, but we can re-open if it's reported again as an issue

@muttmuure I think we're good to close out this one based on the same logic / reasoning mentioned in #48400 (comment).

@melvin-bot melvin-bot bot removed the Overdue label Nov 5, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@ikevin127
Copy link
Contributor

We had a similar issue here which was closed as NAB:

the consensus there was that it is expected to still have RBR show because of existing violations, see #48400 (comment):

  • The red circle on showing on the report preview is working as intended, because the report has violations and we show that no matter what the state of the report is.
  • After paying, the red circle should remain in the report preview, for the same reason as in the first bullet
  • After clearing the cache, the report preview isn't showing the red circle, and after clicking on the preview, the transaction previews aren't showing the red circle. These are bugs because they should be showing for the same reason as in the first bullet

The #48400 (comment) that the issue was closed with:

From this #48400 (comment), seems part of the behavior is expected. Closing it out for now, but we can re-open if it's reported again as an issue

This seems to be a dupe of that so I think we're good to close it as NAB.

cc @muttmuure

Copy link

melvin-bot bot commented Nov 18, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@ikevin127
Copy link
Contributor

♻️ Update: We're expecting this issue to be fixed by the solution proposed in issue #52037, we're working on opening the PR as the contributor was just assigned. I will get back with a retest request for this issue once that PR is merged and deployed.

Copy link

melvin-bot bot commented Nov 25, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Dec 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@ikevin127
Copy link
Contributor

PR #52988 from issue #52037 was merged. We should re-test this to see whether that PR fixed this as well and if it did - we can close as fixed.

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Dec 16, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
@ikevin127
Copy link
Contributor

PR #52988 from issue #52037 was merged. We should re-test this to see whether that PR fixed this as well and if it did - we can close as fixed.

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
Copy link

melvin-bot bot commented Dec 23, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Dec 30, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 30, 2024
@ikevin127
Copy link
Contributor

PR #52988 from issue #52037 was merged. We should re-test this to see whether that PR fixed this as well and if it did - we can close as fixed.

@melvin-bot melvin-bot bot removed the Overdue label Jan 1, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants