[$250] Web - Workspace - Onyx and DOMException console errors appear when uploading workspace picture

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.18-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4837010&group_by=cases:section_id&group_id=229065&group_order=asc
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new Gmail account
3. Create a workspace
4. Navigate to Workspace settings - Profile
5. Click on Edit photo - Upload photo
6. Upload any photo

Expected Result:

There shouldn't be any console errors when uploading a workspace picture.

Actual Result:

Onyx and DOMException console errors appear when uploading a workspace picture.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

log.txt

Bug6566433_1723189504458.bandicam_2024-08-09_09-34-52-799.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015036ca3d15e0f1c7
• Upwork Job ID: 1823749808548336240
• Last Price Increase: 2024-12-19
• Automatic offers:
• allgandalf | Contributor | 105441400
• shubham1206agra | Contributor | 105441407

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[zanyrenney]

This seems like a internal issue. I'm going to apply the internal label and see if we can get some more eyes on this!

[zanyrenney]

took another look. i think this can be external!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015036ca3d15e0f1c7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[zanyrenney]

similar issue #23468

[AlfredoAlc]

Edited by proposal-police: This proposal was edited at 2024-09-03 18:27:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onyx and DOMException console errors appear when uploading a workspace picture.

What is the root cause of that problem?

The error is caused by saving a File to Onix store, we can only store serializable data. This is happening in the SaveResponseInOnyx middleware.

Inside of that middleware we do some checks to determine if we should apply or update the response we receive. In this case, we get all the way to the saveUpdateInformation function which calls Onyx.set() with the following params:

const responseToApply = {
    type: CONST.ONYX_UPDATE_TYPES.HTTPS,
    lastUpdateID: Number(response?.lastUpdateID ?? 0),
    previousUpdateID: Number(response?.previousUpdateID ?? 0),
    request,
    response: response ?? {},
};

The request prop has the Image File inside of it which is causing the error.

What changes do you think we should make in order to solve the problem?

Remove the File from the request prop if exists. I recommend doing this in the saveUpdateInformation function. We can also include only some information like the name of the file if needed.

With this change we could fix also the similar issue mentioned above and prevent having this errors on any other calls that saves files.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@ahmedGaber93, @zanyrenney Huh... This is 4 days overdue. Who can take care of this?

[ahmedGaber93]

Reviewing today

[ahmedGaber93]

I think this similar to #44824, asking if it will fix there or not #44824 (comment)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@ahmedGaber93 @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ahmedGaber93]

@shubham1206agra I don't have an installed environment on window machine, It reproduced with me before on Mac but not on the latest main now. Can you share a reproducible video on your machine with the latest main?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

Also unable to reproduce, seems like this is not a current or critical bug - closing.

[AlfredoAlc]

I can see it now while trying to replace a receipt.

Screen.Recording.2024-09-07.at.8.36.24.a.m.mov

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[allgandalf]

@ahmedGaber93 i was able to reproduce this one, mind if i take over as C+ ?

[ahmedGaber93]

@allgandalf Not at all, please proceed. Thanks!

[allgandalf]

Proposal from @shubham1206agra LGTM! , this will solve the error we get!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allgandalf]

Also please assign me here 😅

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allgandalf]

not overdue

[shubham1206agra]

Just figuring out the best fix here.

[melvin-bot]

@cristipaval, @zanyrenney, @shubham1206agra, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[allgandalf]

not overdue, still waiting for clarification