Add Merge Account to NewExpensify

[zanyrenney]

DESIGN DOC ➡️

Proposal

Tasks

• Post Proposal (full Problem/Solution statement) in #whatsnext
• Wait at least one full business day, and until the post has a majority (2/3) of positive reactions (👍)
• Paste Proposal in the space above with a link to the Slack thread
• Email [email protected] and paste in the Proposal
• Host a pre-design meeting (example) in an appropriate slack channel to discuss any necessary details in public before filling out the High-level of proposed solution section.
• Fill out the High-level overview of the problem, Timeline, Terminology, and High-level of proposed solution sections of the Design Doc
• Email [email protected] (continue the same email chain as before - your last message should be the WN Proposal) with the link to your Design Doc containing your high-level problem and solution
• Add the DesignDocReview label to get the High-level overview of the problem and High-level of proposed solution section reviewed
• Respond to any questions or concerns and bring up blockers in Slack to get a consensus if necessary
• Confirm that the doc has the minimum necessary number of reviews before proceeding
• Host another pre-design meeting in the appropriate slack channel to ask for engineering feedback on the technical solution.
• Fill out the Detailed implementation of the solution and related sections.
• Re-add the DesignDocReview label to this issue
• Respond to any questions or concerns and bring up blockers in Slack to get consensus if necessary
• Confirm that the doc has the minimum necessary number of reviews before proceeding
• Email [email protected] one last time to let them know the Design Doc is moving into the implementation phase
• Implement the changes
• Add regression tests so that QA can test your feature with every deploy (instructions)
• Send out a follow up email to [email protected] once everything has been implemented and do a Project Wrap-Up retrospective that provides:
  • Summary of what we accomplished with this project
  • What went well?
  • What could we have done better?
  • What did we learn?

Issue Owner

Current Issue Owner: @marcaaron

[melvin-bot]

Current assignees @twisterdotcom and @zanyrenney are eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

[zanyrenney]

Edited by proposal-police: This proposal was edited at 2024-08-19 15:59:41 UTC.

Need to improve this but startign with the P/S

Proposal: add the remaining account settings to new dot, Part 1: Merge Account (Part 2: Device Management TBC)

Problem:

When users accidentally create personal accounts while their company is using Expensify, they face several issues. They must either:

• Re-scan their receipts using their company account.
• Manually create expenses within their company account.
• Accept that they won’t be reimbursed by their employer.

Generally, users can’t share reports directly with their company in-app, and managing two accounts can be confusing. Users might also unknowingly create expenses that don't align with company policies.

Solution:

Rebuild the ability to "Merge Accounts" in NewExpensify. This feature allows users to easily merge their personal and company accounts on Expensify.

This will improve the transfer from individual expense data to company-created accounts, giving visibility to admins and mitigating the need to create a novel account for those originally creating individual accounts.

[zanyrenney]

Pre-design on merging accounts for workspace feed/card conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1723841346915409

[zanyrenney]

Proposal: Add the remaining account settings to NewExpensify.

Part 1: Merge Account
Part 2: Consider implications for this on Device Management (TBC)

Problem:

When users accidentally create personal accounts while their company is using Expensify, they face several issues. They must either:

• Re-scan their receipts using their company account.
• Manually create expenses within their company account.
• Accept that they won’t be reimbursed by their employer.

Generally, users can’t share reports directly with their company in-app, and managing two accounts can be confusing. Users might also unknowingly create expenses that don't align with company policies.

Solution:

Rebuild the ability to "Merge Accounts" in NewExpensify. This feature allows users to easily merge their personal and company accounts on Expensify.

This will improve the transfer from individual expense data to company-created accounts, giving visibility to admins and mitigating the need to create a novel account for those originally creating individual accounts, and crucially, give them the ability to do take this action without requiring access to Expensify Classic.

[github-actions]

@zanyrenney Your proposal will be dismissed because you did not follow the proposal template.

[zanyrenney]

This is a bit mean, I haven't even done it yet 🥲

[zanyrenney]

https://github.com/search?q=org:Expensify+%22merge+account%22&type=Code

[zanyrenney]

https://github.com/search?q=org:Expensify+%22merge+account%22&type=Code
https://github.com/Expensify/Web-Expensify/blob/main/script/bwm/HandleBackgroundTasksOnMergeAccount.php
https://github.com/Expensify/Auth/blob/main/auth/command/MergeAccount.cpp

[zanyrenney]

Not sure we need @dannymcclain here yet so will remove this from clogging up his K2.

[zanyrenney]

[zanyrenney]

@twisterdotcom and I considered getting the pre-design out today or tomorrow but I realised we need to email strat@ prior, so done that and then can get the pre-design in flight!

[twisterdotcom]

Back from some OOO. @zanyrenney has been predesigning in a canvas in my absence.

[zanyrenney]

pre-design is posted! https://expensify.slack.com/archives/C06ML6X0W9L/p1725276863731789

[melvin-bot]

👋 Hello Generalist Track Team - you have been assigned to review this Detailed Design Doc. Check out this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment button in the right hand side K2 panel or follow these instructions.

---

• @zsgreenwald (Any Expensifiers, Non-Engineering Graduates or Project Managers) - Detailed design doc review (Any Expensifiers, Non-Engineering Graduates or Project Managers) - Add Merge Account to NewExpensify #54214
• @CortneyOfstad (Any Expensifiers, Non-Engineering Graduates or Project Managers) - Detailed design doc review (Any Expensifiers, Non-Engineering Graduates or Project Managers) - Add Merge Account to NewExpensify #54215
• @danielrvidal (Non-engineering Product Managers or Generalists) - Detailed design doc review (Non-engineering Product Managers or Generalists) - Add Merge Account to NewExpensify #54216
• @isabelastisser (Non-engineering Product Managers or Generalists) - Detailed design doc review (Non-engineering Product Managers or Generalists) - Add Merge Account to NewExpensify #54217
• @aldo-expensify (Engineering Graduates) - Detailed design doc review (Engineering Graduates) - Add Merge Account to NewExpensify #54218
• @tylerkaraszewski (Engineering Graduates) - Detailed design doc review (Engineering Graduates) - Add Merge Account to NewExpensify #54219
• @flodnv (Engineering Graduates) - Detailed design doc review (Engineering Graduates) - Add Merge Account to NewExpensify #54220
• @AndrewGable (Engineering Product Managers or Generalists) - Detailed design doc review (Engineering Product Managers or Generalists) - Add Merge Account to NewExpensify #54221

[marcaaron]

Finished the manual QA section and cleaned up the doc. It's out for final review now!

[aldo-expensify]

I have read and reviewed this Design Doc!

[CortneyOfstad]

I have read and reviewed this Design Doc!

[flodnv]

I have read and reviewed this Design Doc!

[marcaaron]

Detailed in review now!

@tylerkaraszewski @zsgreenwald @danielrvidal @AndrewGable if there's any chance of finishing your reviews sooner vs later that would be great. It's a pretty short one and I'd like to get all the GitHubs created (and possibly implement a few things) over the holiday. Or at least have things ready to pass off to someone else since I'm going on leave around EOM.

[danielrvidal]

I have read and reviewed this Design Doc!

[zanyrenney]

🤦🏼 I obviously did not mean to close. reopened and added back to the right section of the board.

[AndrewGable]

I have read and reviewed this Design Doc!

[deetergp]

I have read and reviewed this Design Doc!

[marcaaron]

This is moving into implementation. @zanyrenney Here are the GH issues:

https://github.com/Expensify/Expensify/issues/455378
https://github.com/Expensify/Expensify/issues/455380
https://github.com/Expensify/Expensify/issues/455382
https://github.com/Expensify/Expensify/issues/455383
#54443

[marcaaron]

Looking for someone to take this over. I could start on the backend PRs, but unsure if I will be able to finish them so might make sense to hand off at this point.

[arosiclair]

Looking for someone to take this over. I could start on the backend PRs, but unsure if I will be able to finish them so might make sense to hand off at this point.

Hey I finally took a look at the high level. I can take over once you're out!