[HOLD for new search] Shortcuts - Subtitle update is required for CTRL+K shortcut because old "Search" is renamed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.82-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Open Keyboard shortcuts menu via CTRL+J

Expected Result:

The subtitle for CTRL+K should be updated to "Open find" or "Open chat finder", because the old Search has been renamed and the new Search is another thing

Actual Result:

The subtitle for CTRL+K is still "Open search dialog"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6510241_1718167137783.bandicam_2024-06-12_12-28-46-015.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The subtitle for CTRL+K is still "Open search dialog".

What is the root cause of that problem?

The root cause is that we didn't update the copy associated with keyboardShortcutsPage.shortcuts.search key in en.ts and es.ts file.

App/src/languages/en.ts

Lines 2781 to 2787 in 8d11d0b

	keyboardShortcutsPage: {
	title: 'Keyboard shortcuts',
	subtitle: 'Save time with these handy keyboard shortcuts:',
	shortcuts: {
	openShortcutDialog: 'Opens the keyboard shortcuts dialog',
	escape: 'Escape dialogs',
	search: 'Open search dialog',

What changes do you think we should make in order to solve the problem?

we can update the copeis on both files to be search: 'Open chat finder' and change the Spanish copy to search: 'Abrir buscador de chat'

What alternative solutions did you explore? (Optional)

We can rename the SEARCH object and its descriptionKey property to 'FIND' and 'find' here, and add 'find' key to keyboardShortcutsPage.shortcuts in en.ts and es.ts file with their corresponding updated copy.

Result:

Screen.Recording.2024-06-12.at.4.25.30.in.the.afternoon.mp4

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mallenexpensify]

We have 'new search' coming out soon. I want to hold on that project to ensure we get the copy correct.

[mallenexpensify]

Holding on new search

[mallenexpensify]

Holding on new search

[mallenexpensify]

Still holding

[mallenexpensify]

Hold

[mallenexpensify]

ooooh, some version of new search is out, bumping to weekly

[mallenexpensify]

Checking on in #expensify-open-source

Coming from this GH, we have Search in the bottom, middle of LHN and it leads to expense search. We also have 🔍 in upper right corner that shows Search as the tooltip. Are we planning to keep these the same or update the text for one?

[mallenexpensify]

No action on the post, marking 'not a priority' and closing