[HOLD #41020] New search - Console error shows up when returning to previous page from Hold request in RHP

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User has some submitted some expenses

1. Go to staging.new.expensify.com
2. Go to Account settings > Troubleshoot
3. Click Navigate next to "New Search Page"
4. Click on the expense that does not have fake users
5. Click on the 3-dot menu > Hold expense
6. Click on the back button in RHP

Expected Result:

No console error will show up

Actual Result:

Console error shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6474085_1715104718205.bandicam_2024-05-08_01-49-11-939.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[lanitochka17]

@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[marcaaron]

@thienlnam taking over since I see you working on some fire stuff

[marcaaron]

@luacmartins given that this page appears to be only accessible from the staging debug menu I think we can remove the blocker, but maybe you'll want to add it to whatever milestone you've got for polish issues.

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[luacmartins]

Thanks for the ping @marcaaron! I think this issue is a subset of #41020, but I think we can keep it open to make sure we resolve it as part of #41020 as well.

[luacmartins]

@marcaaron feel free to unassign yourself if you want to

[melvin-bot]

@luacmartins, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[luacmartins]

Still on hold

[melvin-bot]

@luacmartins, @miljakljajic Eep! 4 days overdue now. Issues have feelings too...

[luacmartins]

Gonna move this to monthly since the holding issue is also put on hold until after the August release.

[miljakljajic]

still holding

[luacmartins]

This is no longer reproducible. Closing!