[Payment Request] [$250] [Search v1] Add canned searches to SearchFilters

[luacmartins]

Section from design doc - https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit#bookmark=id.17106yfpjaun

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013c617a911681a508
• Upwork Job ID: 1790718907539705856
• Last Price Increase: 2024-05-15

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Taking off hold, we'll start implementation shortly.

[Kicu]

hey I can take this and start working today

[luacmartins]

@Kicu let's focus on the issues I shared in Slack first, since the backend for this is still not ready:

• [HOLD] [$250] [Search v1] Refactor RHP flow to contain navigation within itself #41020
• [HOLD for payment 2024-06-11] [$250] [Search v1] Implement sorting #39892
• [HOLD for payment 2024-06-28] [$250] [Search v1] Live search updates #41626

[melvin-bot]

Triggered auto assignment to @strepanier03 (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

@strepanier03, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Still on hold

[jnowakow]

I'll do it as part of work on canned searches (#41624, #41623, #41620)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add canned searches #42184

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @jnowakow does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[parasharrajat]

Regression Test Steps

1. Go to new Search Page. Use Profile > Troubleshoot > New search page if page is not active.
2. There should be 4 options to pick on the left sidebar.
3. Make sure clicking on those changes the search list on the right. (Only Expenses is supported till today).

Do you agree 👍 or 👎 ?

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @parasharrajat owed $250 via NewDot
• Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1790718907539705856/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[strepanier03]

Payment summary

• $250 - @parasharrajat via New Expensify Manual Request

@JmillsExpensify request incoming.

[parasharrajat]

@strepanier03 Feel free to close this issue if nothing is left on it. I will request it later.

[luacmartins]

Closing as per the comment above.

[parasharrajat]

Payment requested as per #41625 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat