Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥼 feat: Dynamic list of all collaborators for this repo! #203

Closed
wants to merge 7 commits into from

Conversation

ArnavK-09
Copy link
Contributor

Closes #85

Screen shots:;

Screenshot_2024-02-06-01-15-45-57
Screenshot_2024-02-06-01-14-12-18_40deb401b9ffe8e1df2f1cc5ba480b12

@ArnavK-09
Copy link
Contributor Author

@pnu-s @codeurimpulsif 👋 hey can you please review and merge this pr and #202

@@ -0,0 +1,14 @@
<div class="row justify-content-md-center">
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }}
{{ $data := getJSON "https://api.github.com/orgs/Exodus-Privacy/members" }}

or

Suggested change
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }}
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/exodus/contributors" }}

Copy link
Contributor Author

@ArnavK-09 ArnavK-09 Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a min,

We want org members or inactive contributors?

Repo of website or app or exodus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }}
{{ $data := getJSON "https://api.github.com/orgs/Exodus-Privacy/members" }}

or

Suggested change
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/website/contributors" }}
{{ $data := getJSON "https://api.github.com/repos/Exodus-Privacy/exodus/contributors" }}

#85 (comment)

@ArnavK-09
Copy link
Contributor Author

  • Fixed markdownlint

Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks but I don't think it's a good thing to add this kind of automated listing from Github (it show old contributors), also not everyone in this list want to be in the Exodus Privacy website or want to use the Github description as a description on the Exodus Privacy website. And this method delete lot of users links.

Also: I don't think we want to make a query to Github for this.

@ArnavK-09
Copy link
Contributor Author

Hi, thanks but I don't think it's a good thing to add this kind of automated listing from Github (it show old contributors), also not everyone in this list want to be in the Exodus Privacy website or want to use the Github description as a description on the Exodus Privacy website. And this method delete lot of users links.

Also: I don't think we want to make a query to Github for this.

Ohh mate I just tried to solve an issue #85

@ArnavK-09 ArnavK-09 closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add list of collaborators
3 participants