Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app_setup key config #361

Merged
merged 3 commits into from
Dec 9, 2023
Merged

Remove app_setup key config #361

merged 3 commits into from
Dec 9, 2023

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Nov 28, 2023

With support to Android 13, we have introduced a new datastore preference class to store key_config. But we have introduced app_setup key config and this key is useless. This value is updated each time we launch the service to refresh reports and trackers.

  • This PR removed the key, I have generated release before and after changes, and I didn't encounter any problems.
  • Tests is OK

And I have updated one code line to reduce information written in logcat because before we write all information foreach app.

@Jean-BaptisteC Jean-BaptisteC requested a review from a user November 28, 2023 18:23
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, everything went fine ;)

@Jean-BaptisteC Jean-BaptisteC merged commit efa762f into master Dec 9, 2023
1 check passed
@Jean-BaptisteC Jean-BaptisteC deleted the remove_key_config branch December 9, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant