Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update export link when filtering trackers #28

Open
ammelanie opened this issue Apr 24, 2019 · 4 comments
Open

Update export link when filtering trackers #28

ammelanie opened this issue Apr 24, 2019 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@ammelanie
Copy link
Contributor

We now have the possibility to search trackers by name, but export JSON link exports all trackers even if there is a filter.

I think that can be disturbing for users. I have some ideas to improve this:

  • Be able to export filtered trackers, can it be useful?
  • Change text to something link Export all trackers as JSON instead of Export as JSON
  • Hide export link while filtering

What do you prefer? Do you have any other ideas?

@pnu-s
Copy link
Member

pnu-s commented Apr 24, 2019

@jawz101 Do you have an opinion on this? Thanks! :)

@jawz101
Copy link

jawz101 commented Apr 24, 2019

I just like having the option to export all trackers to be able to sort & shuffle and see where all of the trackers stand (find fields missing info and whatnot.) Anything more would be overengineering for what I had in mind but if someone else has extra uses for extra features I would think it would be a good thing.

*I currently do not see where the export button shows up if there is one live now.

@pnu-s
Copy link
Member

pnu-s commented Apr 24, 2019

@jawz101 I just released the new version of ETIP, so now you should see the export link :). Feel free to give your feedback on it.

I think right now we can do one of the following (I do not have a strong preference between these):

  • Change text to something link Export all trackers as JSON instead of Export as JSON
  • Hide export link while filtering

@jawz101
Copy link

jawz101 commented Apr 24, 2019

The export button works great to me. I'd say just have it as "export all trackers".

@pnu-s pnu-s added the enhancement New feature or request label May 2, 2019
@pnu-s pnu-s added the good first issue Good for newcomers label May 29, 2019
@pnu-s pnu-s changed the title Export link while filtering trackers by name Update export link when filtering trackers Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Development

No branches or pull requests

3 participants