Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job to validate deployedContracts.json and contract verification #117

Open
coderabbitai bot opened this issue Oct 21, 2024 · 1 comment
Open
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2024

As per PR #112 and this comment, @adu-web3 requested to add a CI job to:

  1. Check that deployedContracts.json exists
  2. Ensure necessary fields exist
  3. Verify that deployed contracts are verified on Etherscan (otherwise we cannot retrieve their storage layout)
@adu-web3
Copy link
Collaborator

another approach is that: we could compare the storage layout against the base(main) branch instead of against the deployed contracts, which might be easier to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant