Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: need docs to elaborate on oracleInfo for addWhitelistToken #105

Open
adu-web3 opened this issue Sep 30, 2024 · 1 comment
Open

doc: need docs to elaborate on oracleInfo for addWhitelistToken #105

adu-web3 opened this issue Sep 30, 2024 · 1 comment

Comments

@adu-web3
Copy link
Collaborator

Description

When the contract owner calls addWhitelistToken, it needs to pass in the oracle info, which is a string, which is constructed by joining at least three params needed with ,. We need to add doc to tell the caller how to construct valid oracle info string to avoid the oracle info being invalid

@adu-web3 adu-web3 changed the title doc: oracleInfo for addWhitelistToken need docs to elaborate on its valid construction doc: need docs to elaborate on oracleInfo for addWhitelistToken Sep 30, 2024
@adu-web3
Copy link
Collaborator Author

adu-web3 commented Oct 9, 2024

maybe we should even use struct, instead of a string, to represent oracle info, so that it would be easier to construct this param. @MaxMustermann2 what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant