Fix for Sh > 2.* issue, and new environment files and template for running on maths2 (Exeter) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fortran compilers, intel mpi, hdf5, netcdf-c and netcdf-fortran all compiled from scratch.
…f they are sh.RunningCommand types. If they are, then their output is decded as a str, and if not the output is left alone.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
daw538
approved these changes
Jul 26, 2023
…ction this cd command is never invoked, so I will try removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #247, versions of
sh>2.*have been causing the isca python front-end to fail. This is becausesh>2.*has changed the default return type of some of its commands, returningstrtypes rather thansh.RunningCommand.This fix adds a new function to check the type of sh outputs and only asks for
.stdoutwhen ash.RunningCommandtype is returned. This should allow the front end to function with versions ofsh=1.*andsh=2.*.Also included here are new environment files and template files for running with intel compilers on Exeter's new maths2 machine. They are included here for my own convenience, but should be of use to others.