Identify locations

Exawind · Nov 22, 2024 · ba927e2 · ba927e2
1 parent 3191948
commit ba927e2
Show file tree

Hide file tree

Showing 83 changed files with 163 additions and 4 deletions.
diff --git a/amr-wind/diffusion/incflo_diffusion.cpp b/amr-wind/diffusion/incflo_diffusion.cpp
@@ -221,6 +221,7 @@ void viscosity_to_uniform_space(
         repo.get_mesh_mapping_det_j(amr_wind::FieldLoc::ZFACE);
 
     // beta accounted for mesh mapping (x-face) = J/fac^2 * mu
+    // needs openmp pragma?
     for (amrex::MFIter mfi(b[0]); mfi.isValid(); ++mfi) {
         amrex::Array4<amrex::Real> const& mu = b[0].array(mfi);
         amrex::Array4<amrex::Real const> const& fac =
@@ -235,6 +236,7 @@ void viscosity_to_uniform_space(
             });
     }
     // beta accounted for mesh mapping (y-face) = J/fac^2 * mu
+    // needs openmp pragma?
     for (amrex::MFIter mfi(b[1]); mfi.isValid(); ++mfi) {
         amrex::Array4<amrex::Real> const& mu = b[1].array(mfi);
         amrex::Array4<amrex::Real const> const& fac =
@@ -249,6 +251,7 @@ void viscosity_to_uniform_space(
             });
     }
     // beta accounted for mesh mapping (z-face) = J/fac^2 * mu
+    // needs openmp pragma?
     for (amrex::MFIter mfi(b[2]); mfi.isValid(); ++mfi) {
         amrex::Array4<amrex::Real> const& mu = b[2].array(mfi);
         amrex::Array4<amrex::Real const> const& fac =

diff --git a/amr-wind/equation_systems/CompRHSOps.H b/amr-wind/equation_systems/CompRHSOps.H
@@ -79,6 +79,7 @@ struct ComputeRHSOp
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(field(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();
                 auto fld = field(lev).array(mfi);
@@ -199,6 +200,7 @@ struct ComputeRHSOp
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(field(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();
                 auto fld = field(lev).array(mfi);

diff --git a/amr-wind/equation_systems/DiffusionOps.cpp b/amr-wind/equation_systems/DiffusionOps.cpp
@@ -128,6 +128,7 @@ void DiffSolverIface<LinOp>::linsys_solve_impl()
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+        // this one
         for (amrex::MFIter mfi(rhs, amrex::TilingIfNotGPU()); mfi.isValid();
              ++mfi) {
             const auto& bx = mfi.tilebox();

diff --git a/amr-wind/equation_systems/PDEOps.H b/amr-wind/equation_systems/PDEOps.H
@@ -100,6 +100,7 @@ struct SrcTermOpBase
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(src_term, amrex::TilingIfNotGPU());
                  mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();

diff --git a/amr-wind/equation_systems/density/density_ops.H b/amr-wind/equation_systems/density/density_ops.H
@@ -30,6 +30,7 @@ struct ComputeRHSOp<Density, Scheme>
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(field(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();
                 auto rho = field(lev).array(mfi);
@@ -62,6 +63,7 @@ struct ComputeRHSOp<Density, Scheme>
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(field(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();
                 auto rho = field(lev).array(mfi);

diff --git a/amr-wind/equation_systems/icns/icns_advection.cpp b/amr-wind/equation_systems/icns/icns_advection.cpp
@@ -336,6 +336,8 @@ void MacProjOp::mac_proj_to_uniform_space(
     // scale U^mac to accommodate for mesh mapping -> U^bar = J/fac *
     // U^mac beta accounted for mesh mapping = J/fac^2 * 1/rho construct
     // rho and mesh map u_mac on x-face
+    // this one
+    // needs openmp pragma?
     for (amrex::MFIter mfi(*(rho_face[0])); mfi.isValid(); ++mfi) {
         amrex::Array4<amrex::Real> const& u = u_mac(lev).array(mfi);
         amrex::Array4<amrex::Real> const& rho = rho_face[0]->array(mfi);
@@ -352,6 +354,8 @@ void MacProjOp::mac_proj_to_uniform_space(
             });
     }
     // construct rho on y-face
+    // this one
+    // needs openmp pragma?
     for (amrex::MFIter mfi(*(rho_face[1])); mfi.isValid(); ++mfi) {
         amrex::Array4<amrex::Real> const& v = v_mac(lev).array(mfi);
         amrex::Array4<amrex::Real> const& rho = rho_face[1]->array(mfi);
@@ -368,6 +372,8 @@ void MacProjOp::mac_proj_to_uniform_space(
             });
     }
     // construct rho on z-face
+    // this one
+    // needs openmp pragma?
     for (amrex::MFIter mfi(*(rho_face[2])); mfi.isValid(); ++mfi) {
         amrex::Array4<amrex::Real> const& w = w_mac(lev).array(mfi);
         amrex::Array4<amrex::Real> const& rho = rho_face[2]->array(mfi);

diff --git a/amr-wind/equation_systems/icns/icns_diffusion.H b/amr-wind/equation_systems/icns/icns_diffusion.H
@@ -169,6 +169,7 @@ public:
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+                // this one
                 for (amrex::MFIter mfi(divtau(lev), amrex::TilingIfNotGPU());
                      mfi.isValid(); ++mfi) {
                     const auto& bx = mfi.tilebox();
@@ -240,6 +241,7 @@ public:
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(rhs, amrex::TilingIfNotGPU()); mfi.isValid();
                  ++mfi) {
                 const auto& bx = mfi.tilebox();
@@ -401,6 +403,7 @@ public:
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+                // this one
                 for (amrex::MFIter mfi(divtau(lev), amrex::TilingIfNotGPU());
                      mfi.isValid(); ++mfi) {
                     const auto& bx = mfi.tilebox();
@@ -483,6 +486,7 @@ public:
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(rhs, amrex::TilingIfNotGPU()); mfi.isValid();
                  ++mfi) {
                 const auto& bx = mfi.tilebox();

diff --git a/amr-wind/equation_systems/icns/icns_ops.H b/amr-wind/equation_systems/icns/icns_ops.H
@@ -93,6 +93,7 @@ struct SrcTermOp<ICNS> : SrcTermOpBase<ICNS>
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(src_term, amrex::TilingIfNotGPU());
                  mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();

diff --git a/amr-wind/equation_systems/levelset/levelset_ops.H b/amr-wind/equation_systems/levelset/levelset_ops.H
@@ -69,6 +69,7 @@ struct ComputeRHSOp<Levelset, Scheme>
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(field(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();
                 auto phi = field(lev).array(mfi);
@@ -101,6 +102,7 @@ struct ComputeRHSOp<Levelset, Scheme>
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+            // this one
             for (amrex::MFIter mfi(field(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();
                 auto phi = field(lev).array(mfi);

diff --git a/amr-wind/equation_systems/tke/tke_ops.H b/amr-wind/equation_systems/tke/tke_ops.H
@@ -42,6 +42,7 @@ struct PostSolveOp<TKE>
         const int nlevels = repo.num_active_levels();
         const auto clip_value = m_clip_value;
         for (int lev = 0; lev < nlevels; ++lev) {
+            // this one
             for (amrex::MFIter mfi(field(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.tilebox();
                 const auto& field_arr = field(lev).array(mfi);

diff --git a/amr-wind/equation_systems/vof/vof_hybridsolver_ops.H b/amr-wind/equation_systems/vof/vof_hybridsolver_ops.H
@@ -19,6 +19,7 @@ static void replace_masked_vof(
         auto& vof = f_vof(lev);
         const auto& vof_new = f_vof_new(lev);
 
+        // this one
         for (amrex::MFIter mfi(iblank); mfi.isValid(); ++mfi) {
             const auto& gbx = mfi.growntilebox();
             const amrex::Array4<const int>& native_flag =

diff --git a/amr-wind/immersed_boundary/bluff_body/bluff_body_ops.cpp b/amr-wind/immersed_boundary/bluff_body/bluff_body_ops.cpp
@@ -47,6 +47,7 @@ void apply_mms_vel(CFDSim& sim)
         const auto& dx = geom[lev].CellSizeArray();
         const auto& problo = geom[lev].ProbLoArray();
 
+        // this one
         for (amrex::MFIter mfi(levelset(lev)); mfi.isValid(); ++mfi) {
             const auto& bx = mfi.growntilebox();
             const auto& phi = levelset(lev).const_array(mfi);
@@ -90,6 +91,7 @@ void apply_dirichlet_vel(CFDSim& sim, const amrex::Vector<amrex::Real>& vel_bc)
         // Defining the "ghost-cell" band distance
         amrex::Real phi_b = std::cbrt(dx[0] * dx[1] * dx[2]);
 
+        // this one
         for (amrex::MFIter mfi(levelset(lev)); mfi.isValid(); ++mfi) {
             const auto& bx = mfi.tilebox();
             const auto& varr = velocity(lev).array(mfi);

diff --git a/amr-wind/immersed_boundary/bluff_body/box_ops.H b/amr-wind/immersed_boundary/bluff_body/box_ops.H
@@ -59,6 +59,7 @@ struct InitDataOp<Box>
         for (int lev = 0; lev < nlevels; ++lev) {
             const auto& problo = geom[lev].ProbLoArray();
             const auto& dx = geom[lev].CellSizeArray();
+            // this one
             for (amrex::MFIter mfi(levelset(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.growntilebox();
                 const auto& epsilon_node = mask_node(lev).array(mfi);

diff --git a/amr-wind/immersed_boundary/bluff_body/cylinder_ops.H b/amr-wind/immersed_boundary/bluff_body/cylinder_ops.H
@@ -58,6 +58,7 @@ struct InitDataOp<Cylinder>
             const auto& problo = geom[lev].ProbLoArray();
             const auto& dx = geom[lev].CellSizeArray();
 
+            // this one
             for (amrex::MFIter mfi(levelset(lev)); mfi.isValid(); ++mfi) {
                 const auto& phi = levelset(lev).array(mfi);
 

diff --git a/amr-wind/immersed_boundary/bluff_body/sphere_ops.H b/amr-wind/immersed_boundary/bluff_body/sphere_ops.H
@@ -56,6 +56,7 @@ struct InitDataOp<Sphere>
             const auto& problo = geom[lev].ProbLoArray();
             const auto& dx = geom[lev].CellSizeArray();
 
+            // this one
             for (amrex::MFIter mfi(levelset(lev)); mfi.isValid(); ++mfi) {
                 const auto& bx = mfi.growntilebox();
                 const auto& phi = levelset(lev).array(mfi);

diff --git a/amr-wind/mesh_mapping_models/ChannelFlowMap.cpp b/amr-wind/mesh_mapping_models/ChannelFlowMap.cpp
@@ -70,6 +70,7 @@ void ChannelFlowMap::create_cell_node_map(int lev, const amrex::Geometry& geom)
         prob_hi[0] - prob_lo[0], prob_hi[1] - prob_lo[1],
         prob_hi[2] - prob_lo[2]};
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_cc)(lev)); mfi.isValid(); ++mfi) {
 
         const auto& bx = mfi.growntilebox();
@@ -149,6 +150,7 @@ void ChannelFlowMap::create_face_map(int lev, const amrex::Geometry& geom)
         prob_hi[0] - prob_lo[0], prob_hi[1] - prob_lo[1],
         prob_hi[2] - prob_lo[2]};
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_xf)(lev)); mfi.isValid(); ++mfi) {
 
         const auto& bx = mfi.growntilebox();
@@ -181,6 +183,7 @@ void ChannelFlowMap::create_face_map(int lev, const amrex::Geometry& geom)
             });
     }
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_yf)(lev)); mfi.isValid(); ++mfi) {
 
         const auto& bx = mfi.growntilebox();
@@ -213,6 +216,7 @@ void ChannelFlowMap::create_face_map(int lev, const amrex::Geometry& geom)
             });
     }
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_zf)(lev)); mfi.isValid(); ++mfi) {
 
         const auto& bx = mfi.growntilebox();
@@ -277,6 +281,7 @@ void ChannelFlowMap::create_non_uniform_mesh(
         probhi_physical[0] - prob_lo[0], probhi_physical[1] - prob_lo[1],
         probhi_physical[2] - prob_lo[2]};
 
+    // this one
     for (amrex::MFIter mfi((*m_non_uniform_coord_cc)(lev)); mfi.isValid();
          ++mfi) {
 

diff --git a/amr-wind/mesh_mapping_models/ConstantMap.cpp b/amr-wind/mesh_mapping_models/ConstantMap.cpp
@@ -27,6 +27,7 @@ void ConstantMap::create_cell_node_map(int lev)
     amrex::Real fac_y = m_fac[1];
     amrex::Real fac_z = m_fac[2];
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_cc)(lev)); mfi.isValid(); ++mfi) {
 
         const auto& bx = mfi.growntilebox();
@@ -69,6 +70,7 @@ void ConstantMap::create_face_map(int lev)
     amrex::Real fac_y = m_fac[1];
     amrex::Real fac_z = m_fac[2];
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_xf)(lev)); mfi.isValid(); ++mfi) {
         const auto& bx = mfi.growntilebox();
         amrex::Array4<amrex::Real> const& scale_fac_xf =
@@ -86,6 +88,7 @@ void ConstantMap::create_face_map(int lev)
             });
     }
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_yf)(lev)); mfi.isValid(); ++mfi) {
         const auto& bx = mfi.growntilebox();
         amrex::Array4<amrex::Real> const& scale_fac_yf =
@@ -103,6 +106,7 @@ void ConstantMap::create_face_map(int lev)
             });
     }
 
+    // this one
     for (amrex::MFIter mfi((*m_mesh_scale_fac_zf)(lev)); mfi.isValid(); ++mfi) {
         const auto& bx = mfi.growntilebox();
         amrex::Array4<amrex::Real> const& scale_fac_zf =
@@ -129,6 +133,7 @@ void ConstantMap::create_non_uniform_mesh(int lev, const amrex::Geometry& geom)
     const auto& problo = geom.ProbLoArray();
     const auto& dx = geom.CellSizeArray();
 
+    // this one
     for (amrex::MFIter mfi((*m_non_uniform_coord_cc)(lev)); mfi.isValid();
          ++mfi) {
 

diff --git a/amr-wind/ocean_waves/relaxation_zones/linear_waves_ops.H b/amr-wind/ocean_waves/relaxation_zones/linear_waves_ops.H
@@ -45,6 +45,7 @@ struct InitDataOp<LinearWaves>
         const auto& problo = geom.ProbLoArray();
         const auto& probhi = geom.ProbHiArray();
         const auto& dx = geom.CellSizeArray();
+        // this one
         for (amrex::MFIter mfi(m_levelset(level)); mfi.isValid(); ++mfi) {
 
             const auto& phi = m_levelset(level).array(mfi);
@@ -135,6 +136,7 @@ struct UpdateRelaxZonesOp<LinearWaves>
             const auto& problo = geom[lev].ProbLoArray();
             const auto& dx = geom[lev].CellSizeArray();
 
+            // this one
             for (amrex::MFIter mfi(m_ow_levelset(lev)); mfi.isValid(); ++mfi) {
                 const auto& phi = m_ow_levelset(lev).array(mfi);
                 const auto& vel = m_ow_velocity(lev).array(mfi);

diff --git a/amr-wind/ocean_waves/relaxation_zones/relaxation_zones_ops.cpp b/amr-wind/ocean_waves/relaxation_zones/relaxation_zones_ops.cpp
@@ -64,6 +64,7 @@ void apply_relaxation_zones(CFDSim& sim, const RelaxZonesBaseData& wdata)
         auto& target_vof = m_ow_vof(lev);
         const auto& dx = geom[lev].CellSizeArray();
 
+        // this one
         for (amrex::MFIter mfi(ls); mfi.isValid(); ++mfi) {
             const auto& gbx = mfi.growntilebox(2);
             const amrex::Array4<amrex::Real>& phi = ls.array(mfi);
@@ -87,6 +88,7 @@ void apply_relaxation_zones(CFDSim& sim, const RelaxZonesBaseData& wdata)
     auto& density = sim.repo().get_field("density");
 
     for (int lev = 0; lev < nlevels; ++lev) {
+        // this one
         for (amrex::MFIter mfi(vof(lev)); mfi.isValid(); ++mfi) {
             const auto& gbx = mfi.growntilebox(2);
             const auto& dx = geom[lev].CellSizeArray();

diff --git a/amr-wind/ocean_waves/relaxation_zones/stokes_waves_ops.H b/amr-wind/ocean_waves/relaxation_zones/stokes_waves_ops.H
@@ -84,6 +84,7 @@ struct InitDataOp<StokesWaves>
         const auto& problo = geom.ProbLoArray();
         const auto& probhi = geom.ProbHiArray();
         const auto& dx = geom.CellSizeArray();
+        // this one
         for (amrex::MFIter mfi(m_levelset(level)); mfi.isValid(); ++mfi) {
 
             const auto& phi = m_levelset(level).array(mfi);
@@ -160,6 +161,7 @@ struct UpdateRelaxZonesOp<StokesWaves>
             const auto& problo = geom[lev].ProbLoArray();
             const auto& dx = geom[lev].CellSizeArray();
 
+            // this one
             for (amrex::MFIter mfi(m_ow_levelset(lev)); mfi.isValid(); ++mfi) {
                 const auto& phi = m_ow_levelset(lev).array(mfi);
                 const auto& vel = m_ow_velocity(lev).array(mfi);

diff --git a/amr-wind/ocean_waves/relaxation_zones/waves2amr_ops.H b/amr-wind/ocean_waves/relaxation_zones/waves2amr_ops.H
@@ -82,6 +82,7 @@ void postprocess_velocity_mfab_liquid(
     amrex::MultiFab& lvs_mfab,
     const amrex::GpuArray<amrex::Real, AMREX_SPACEDIM> dx)
 {
+    // this one
     for (amrex::MFIter mfi(vel_mfab); mfi.isValid(); ++mfi) {
         auto vel = vel_mfab.array(mfi);
         auto phi = lvs_mfab.const_array(mfi);
@@ -427,6 +428,7 @@ struct InitDataOp<W2AWaves>
         // Blank initialization if asked for
         if (!init_waves) {
             // Loop to populate field data
+            // this one
             for (amrex::MFIter mfi(levelset(level)); mfi.isValid(); ++mfi) {
                 auto phi = levelset(level).array(mfi);
                 auto vel = velocity(level).array(mfi);
@@ -653,6 +655,7 @@ struct UpdateRelaxZonesOp<W2AWaves>
 
         // Temporally interpolate at every timestep to get target solution
         for (int lev = 0; lev < nlevels; ++lev) {
+            // this one
             for (amrex::MFIter mfi(m_ow_levelset(lev)); mfi.isValid(); ++mfi) {
                 auto phi = m_ow_levelset(lev).array(mfi);
                 auto vel = m_ow_velocity(lev).array(mfi);

diff --git a/amr-wind/overset/OversetOps.cpp b/amr-wind/overset/OversetOps.cpp
@@ -137,6 +137,7 @@ void OversetOps::update_gradp()
 #ifdef AMREX_USE_OMP
 #pragma omp parallel if (amrex::Gpu::notInLaunchRegion())
 #endif
+        // this one
         for (MFIter mfi(grad_p(lev), TilingIfNotGPU()); mfi.isValid(); ++mfi) {
             Box const& tbx = mfi.tilebox();
             Array4<Real> const& gp_lev = grad_p(lev).array(mfi);

diff --git a/amr-wind/physics/BoussinesqBubble.cpp b/amr-wind/physics/BoussinesqBubble.cpp
@@ -32,6 +32,7 @@ void BoussinesqBubble::initialize_fields(int level, const amrex::Geometry& geom)
     auto& density = m_density(level);
     auto& scalars = (*m_temperature)(level);
 
+    // needs openmp pragma?
     for (amrex::MFIter mfi(density); mfi.isValid(); ++mfi) {
         const auto& vbx = mfi.validbox();
 

diff --git a/amr-wind/physics/BurggrafFlow.cpp b/amr-wind/physics/BurggrafFlow.cpp
@@ -63,6 +63,7 @@ void BurggrafFlow::initialize_fields(int level, const amrex::Geometry& geom)
 
     UExact u_exact;
     VExact v_exact;
+    // this one
     for (amrex::MFIter mfi(velocity); mfi.isValid(); ++mfi) {
         const auto& vbx = mfi.validbox();
 
@@ -181,4 +182,4 @@ void BurggrafFlow::post_init_actions() { output_error(); }
 
 void BurggrafFlow::post_advance_work() { output_error(); }
 
-} // namespace amr_wind::burggraf
+} // namespace amr_wind::burggraf