-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in name for PaNET01107 #76
Closed
Labels
bug
Something isn't working
Milestone
Comments
Yes indeed it is a typo. We can update the label. |
spc93
added a commit
that referenced
this issue
Feb 21, 2024
Motivation: Small change that fixes some errors and enables disjoint class relationship (which in turn helps to identify logical inconsistencies, such as a technique being simultaneously elastic and inelastic. The issues addressed are outlined in Milestone-1 and documented below. ........................................ change the label from 'photoemission microscopy' to 'photoemission electron microscopy' (as the preferred name) add 'PEEM' (already included) and 'photoelectron emission microscopy' as alternative names Also needed to: change two references to 'photoemission microscopy' to be 'photoemission electron microscopy' change 'x-ray photoemission microscopy' to 'x-ray photoemission electron microscopy' Closes: #54 ........................................ The name for term PaNET01107 reads inelastic small angle scatteringng. I suspect this is a typo. Label changed to 'inelastic small angle scattering' Closes: #76 ........................................ delete equivalent class 'versus energy' replace subclass (of) 'defined by functional dependence' with subclass 'versus energy' Note: This changes the definition of PaNET01165 (MAD) so it is no longer a spectroscopy Note: subclass of 'defined by functional dependence' is no longer required as 'versus energy' is already a subclass of 'defined by functional dependence' Closes: #53 ........................................... Error in PaNET01107 (inelastic small angle scattering) Change made: 'small angle scattering' (PaNET01124) should be a subclass of 'low momentum transfer scattering' but not 'diffraction' Closes: #104 ........................................... Achieved by adding a 'DC %' column in the csv file (new column Q in csv spreadsheet). Closes #105 ........................................... Change to definition of PaNET01034 ('inelastic scattering') to be disjoint with PaNET01020 ('elastic scattering') Closes #106 ...........................................
spc93
added a commit
that referenced
this issue
Feb 29, 2024
…ring, adds disjoints. Motivation: Small change that fixes some errors and enables disjoint class relationship (which in turn helps to identify logical inconsistencies, such as a technique being simultaneously elastic and inelastic. The issues addressed are outlined in Milestone-1 and documented below. ........................................ change the label from 'photoemission microscopy' to 'photoemission electron microscopy' (as the preferred name) add 'PEEM' (already included) and 'photoelectron emission microscopy' as alternative names Also needed to: change two references to 'photoemission microscopy' to be 'photoemission electron microscopy' change 'x-ray photoemission microscopy' to 'x-ray photoemission electron microscopy' Closes: #54 ........................................ The name for term PaNET01107 reads inelastic small angle scatteringng. I suspect this is a typo. Label changed to 'inelastic small angle scattering' Closes: #76 ........................................ delete equivalent class 'versus energy' replace subclass (of) 'defined by functional dependence' with subclass 'versus energy' Note: This changes the definition of PaNET01165 (MAD) so it is no longer a spectroscopy Note: subclass of 'defined by functional dependence' is no longer required as 'versus energy' is already a subclass of 'defined by functional dependence' Closes: #53 ........................................... Error in PaNET01107 (inelastic small angle scattering) Change made: 'small angle scattering' (PaNET01124) should be a subclass of 'low momentum transfer scattering' but not 'diffraction' Closes: #104 ........................................... Achieved by adding a 'DC %' column in the csv file (new column Q in csv spreadsheet). Closes #105 ........................................... Change to definition of PaNET01034 ('inelastic scattering') to be disjoint with PaNET01020 ('elastic scattering') Closes #106 ...........................................
spc93
added a commit
that referenced
this issue
Apr 11, 2024
… axioms. Motivation: Small change that fixes some errors and enables disjoint class relationship (which in turn helps to identify logical inconsistencies, such as a technique being simultaneously elastic and inelastic. The issues addressed are outlined in Milestone-1 and documented below. ........................................ change the label from 'photoemission microscopy' to 'photoemission electron microscopy' (as the preferred name) add 'PEEM' (already included) and 'photoelectron emission microscopy' as alternative names Also needed to: change two references to 'photoemission microscopy' to be 'photoemission electron microscopy' change 'x-ray photoemission microscopy' to 'x-ray photoemission electron microscopy' Closes: #54 ........................................ The name for term PaNET01107 reads inelastic small angle scatteringng. I suspect this is a typo. Label changed to 'inelastic small angle scattering' Closes: #76 ........................................ delete equivalent class 'versus energy' replace subclass (of) 'defined by functional dependence' with subclass 'versus energy' Note: This changes the definition of PaNET01165 (MAD) so it is no longer a spectroscopy Note: subclass of 'defined by functional dependence' is no longer required as 'versus energy' is already a subclass of 'defined by functional dependence' Closes: #53 ........................................... Error in PaNET01107 (inelastic small angle scattering) Change made: 'small angle scattering' (PaNET01124) should be a subclass of 'low momentum transfer scattering' but not 'diffraction' Closes: #104 ........................................... Achieved by adding a 'DC %' column in the csv file (new column Q in csv spreadsheet). Closes #105 ........................................... Change to definition of PaNET01034 ('inelastic scattering') to be disjoint with PaNET01020 ('elastic scattering') Closes #106 ...........................................
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The name for term PaNET01107 reads
inelastic small angle scatteringng
. I suspect this is a typo.The text was updated successfully, but these errors were encountered: