Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning for SERVER_NAME mistakenly gets printed when TM_SERVER_NAME env variable is set #46

Open
Chris92de opened this issue Sep 13, 2024 · 0 comments · May be fixed by #47
Open

Deprecation warning for SERVER_NAME mistakenly gets printed when TM_SERVER_NAME env variable is set #46

Chris92de opened this issue Sep 13, 2024 · 0 comments · May be fixed by #47

Comments

@Chris92de
Copy link
Member

https://github.com/EvoEsports/docker-trackmania/blob/master/entrypoint.sh#L119
https://github.com/EvoEsports/docker-trackmania/blob/master/entrypoint.sh#L129

Checking the code snippets linked above, you will notice that the deprecation warning was mistakenly added to the if statement checking whether the env variable TM_SERVER_NAME was set, not the elif statement checking for SERVER_NAME.

Should be a simple fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Chris92de