Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error thrown, and example comments #144

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

Tieske
Copy link
Contributor

@Tieske Tieske commented May 23, 2024

replaces #143

please review with whitespace changes turned off.

@laulin please check the updates based on your work

@Tieske
Copy link
Contributor Author

Tieske commented May 23, 2024

@EvandroLG a nice side effect of the close method is that we can get rid of the ugly stop pattern;

instead of:

    local stop = false
    ...
    if something then
      ...
      stop = true
    end
    return stop

this will work:

    ...
    if something then
      ...
      return response:close()
    end

Let me know if you want me to update the other examples with that pattern as well.

@EvandroLG
Copy link
Owner

I liked it, @Tieske
Can I merge it, and then you open a new PR with the other changes?

@Tieske
Copy link
Contributor Author

Tieske commented May 30, 2024

@EvandroLG Please merge, I'll follow up later

@EvandroLG EvandroLG merged commit 5adc7df into EvandroLG:master May 30, 2024
7 checks passed
@Tieske Tieske deleted the fix/laulin branch May 30, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants