Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if link override entity is nil #87

Closed
wants to merge 1 commit into from

Conversation

tonsa1
Copy link
Contributor

@tonsa1 tonsa1 commented Jan 20, 2024

Explained here: #86

df_possible_overrides_from_entity(Arena *arena, DF_Entity *entity) function keeps creating new strings because the override is not valid.
Adding a check for override fixes the issue.

@ryanfleury
Copy link
Collaborator

This issue should be resolved now, with a few of the related paths (notably df_entity_from_path and the file path map view) fixed. I've also manually merged the nil-check in the df_possible_overrides_from_path path.

@ryanfleury ryanfleury closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants