You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When LORA_AT_DEBUG was enabled, we were are not able to get the received Class C messages from the library. After further analysis, it looks like when LORA_AT_DEBUG is enabled, multiple lines from the mode are being consumed when +LOG is found, essentially throwing away the following line that would have contained the information about received message
The issue can be seen when TINY_GSM_DEBUG_DEEP is enabled. An unproblematic example:
Culprit seems to be thisModem().stream.readStringUntil(AT_NL[len_atnl]);
Not sure what the actual intention was: read until the last character of AT_NL or read until end of string / null byte (because AT_NL[len_atnl] is off-by-one)?
Changing it to thisModem().stream.readStringUntil(AT_NL[0]) seems to work in our situation that log messages are processed line by line (using LoRaE5), but there might be a more robust solution
The text was updated successfully, but these errors were encountered:
When
LORA_AT_DEBUG
was enabled, we were are not able to get the received Class C messages from the library. After further analysis, it looks like whenLORA_AT_DEBUG
is enabled, multiple lines from the mode are being consumed when+LOG
is found, essentially throwing away the following line that would have contained the information about received messageThe issue can be seen when
TINY_GSM_DEBUG_DEEP
is enabled. An unproblematic example:Problematic that causes the message not to be processed
Culprit seems to be
thisModem().stream.readStringUntil(AT_NL[len_atnl]);
Not sure what the actual intention was: read until the last character of AT_NL or read until end of string / null byte (because
AT_NL[len_atnl]
is off-by-one)?Changing it to
thisModem().stream.readStringUntil(AT_NL[0])
seems to work in our situation that log messages are processed line by line (using LoRaE5), but there might be a more robust solutionThe text was updated successfully, but these errors were encountered: