Concurrent map read and map write

[inkeliz]

Golang is a language that have a good support for concurrency and multithreading. I'm testing some stuff, as always, but I'm hit at fatal error: concurrent map read and map write.

Seems that Engo isn't capable to support multi-thread by default. There's a lot of map without any mutex:

engo/common/render.go

Lines 277 to 281 in d2790d2

	if _, ok := rs.ids[basic.ID()]; ok {
	return
	}
	rs.ids[basic.ID()] = struct{}{}

engo/common/spritesheet.go

Lines 113 to 127 in d2790d2

	s.cache[index] = Texture{
	id: s.texture,
	width: float32(cell.Width),
	height: float32(cell.Height),
	viewport: engo.AABB{
	Min: engo.Point{
	X: cell.Position.X / s.width,
	Y: cell.Position.Y / s.height,
	},
	Max: engo.Point{
	X: (cell.Position.X + float32(cell.Width)) / s.width,
	Y: (cell.Position.Y + float32(cell.Height)) / s.height,
	},
	},
	}

That error can be triggered with anything like:

for i := 0; i < 10; i++ {
    go func() {
        //...
        element.RenderSystem.Add(
    }()
}

...

---

I'm thinking about create a queued channel, intended to receive and then calls Engo.

There's any plan to support concurrency?

[Noofbiz]

I think supporting concurrency in systems would be an amazing thing! There are a few issues that would need to be worked through, mostly that openGL calls MUST be done on the main thread, the operating system requires it. So the render system or any system that does drawing would have to be guaranteed somehow to run on the main thread.