Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error handling #3

Open
hassankhan opened this issue Nov 1, 2018 · 0 comments
Open

Add better error handling #3

hassankhan opened this issue Nov 1, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@hassankhan
Copy link
Contributor

hassankhan commented Nov 1, 2018

Description

What is the use case that should be solved?

Currently, when the package throws an error, we see a full stack trace:

<PATH_TO_PROJECT>/git-author-check/dist/validateAuthor.js:16
        throw new Error(chalk_1.default.red(message));
        ^

Error: Invalid author email domain! Check that your config contains a definition for your domain.
    at Object.exports.default (<PATH_TO_PROJECT>/git-author-check/dist/validateAuthor.js:16:15)
    at run (<PATH_TO_PROJECT>/git-author-check/dist/index.js:12:29)
    at Object.<anonymous> (<PATH_TO_PROJECT>/git-author-check/dist/index.js:14:1)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Function.Module.runMain (module.js:693:10)
    at startup (bootstrap_node.js:191:16)

We should only show error messages in the console output.

Additional Data

Version of git-author-check you're using: 1.0.1

Node Version: 8.11

Operating System: macOS 10.13

@hassankhan hassankhan added the enhancement New feature or request label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant