Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prompt for breaking changes #11

Open
hassankhan opened this issue Nov 16, 2018 · 0 comments
Open

Add prompt for breaking changes #11

hassankhan opened this issue Nov 16, 2018 · 0 comments
Assignees
@cainakleao
Labels
enhancement New feature or request

Comments

@hassankhan
Copy link
Contributor

hassankhan commented Nov 16, 2018 •
edited
Loading

Description

What is the use case that should be solved?

We should have the prompts ask if a breaking change is being committed. If true, then we should prepend the commit body with BREAKING CHANGE:.

For example:

feat(foo): Add new foo

BREAKING CHANGE: API has now changed

Version of cz-github you're using: 1.0.5

Node Version: 8.11

Operating System: macOS 10.13
@hassankhan hassankhan added the enhancement New feature or request label Nov 16, 2018
cainakleao pushed a commit that referenced this issue Nov 16, 2018
@cainaleaouk
feat(flow): add new flow step
e6dd650 
added a step to check if the commit is a breaking change and append it to the
message

Fixes ##11
@cainakleao cainakleao mentioned this issue Nov 16, 2018
Merged
hassankhan pushed a commit that referenced this issue Nov 20, 2018
@cainaleaouk @hassankhan
feat(flow): add new flow step
4249677 
added a step to check if the commit is a breaking change and append it to the
message

Fixes ##11
esg-bot added a commit that referenced this issue Jun 21, 2020
@esg-bot
chore(release): 2.0.0 [skip ci]
270d2c0 
# [2.0.0](v1.0.5...v2.0.0) (2020-06-21)

### Bug Fixes

* **validation:** change header max length to 72 ([c98d52d](c98d52d))

### Build System

* change minimum supported Node version ([d392e42](d392e42))

### Features

* **flow:** add new flow step ([4249677](4249677)), closes [#11](#11)

### BREAKING CHANGES

* change minimum supported version of Node to v10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cainakleao cainakleao

Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hassankhan @cainakleao