Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Custom "rulesets" with autoloading #1

Open
repsejnworb opened this issue Sep 16, 2022 · 1 comment
Open

[REQUEST] Custom "rulesets" with autoloading #1

repsejnworb opened this issue Sep 16, 2022 · 1 comment
Assignees

Comments

@repsejnworb
Copy link

First off, thanks for a great addon!
I right now use profiles to solve my usecase, but it is a clunky "abuse" making it do what I want.

Request/Proposal

Add support for "overload-ruleset/template" that is easily switched on/off manually and can autoload per zone.
Might require a little restructuring of the current rules in the addon to have a nice UX, but a carbon-copy overload would also work.

So essentially I would like to have AutoLooter setup the way I generally like it. But when I go farm Baron in Strat I want to have a different set of whitelisting/blacklisting/minimum price/quality looted etc, and as I later move to Dire Maul I want another set of rules.
Using profiles for this becomes tedious when I decide to update my "default" profile on something I want all the others to also have.
I.e. having "overload"-profiles/rulesets/templates that inherits/only change what is specifically setup in the "overload" would be a huge boon.

Then being able to setup autoload-rules based on zone/instance and having a quick-access to swapping from the minimap-button.

I would propose to also refactor the settings, if this feature were to be picked up, so that "lootingrules" are consolidated and not mixed with "behaviour/general/misc" settings.

@Eliote
Copy link
Owner

Eliote commented Sep 24, 2022

First off, thanks for a great addon!

Thanks! 😄

This sounds way too complicated, specially for lists. (should I override it, or join it?)
Another problem is how do I know if a config should be overwritten or not. Did the user set it to false/true or was it never changed? It would require a new checkbox for every config, and/or make checkbox triple state.
I use AceConfig to generate the interface and I don't want to create my own, low level wow UI is really painful to do right (at least for me). Also with AceConfig I get CLI for free.

The easiest thing I can think of, is to make an "advanced" configuration where you can temporarily edit the profile with an in-game lua script when changing zones.

Something like:

-- any changes here are momentary, when you change zones this code will be called again with the original values.
local options = ...
if GetZoneText() == "Something" then
  -- ideally those parameters would reflect the "cli" of the addon.
  options.set("price", 2000)
  options.set("rarity", 3)
end

@Eliote Eliote self-assigned this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants