-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Babel dependency #48
Comments
Updating the babel deps breaks the snapshot tests in the project, most of them are similar to:
Most of them look mostly cosmetic. The |
Babel 7 now assumes that files it processes are ES modules, by default. I believe there's a babel configuration to disable that if desired, but I don't see any reason to do so. |
Yeah I thought the same, but the commonjs'ness of element-ui gave me pause. // test/fixtures/conditions/expected.js
"use strict";
require("element-ui/lib/select/style.css");
var _select = _interopRequireDefault(require("element-ui/lib/select"));
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
if (a === _select["default"]) { }
if (_Select) { }
_Select ? 'a' : 'b';
a ? _Select : 2;
_Select || 'a';
a || _Select; Another mystery guest: ( // test/fixtures/import-all-css/expected.js
"use strict";
require("element-ui/lib/style.css");
var _lib = _interopRequireDefault(require("element-ui/lib"));
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
console.log(_lib["default"].Button);
console.log(_Element); And one more: (same as above) // test/fixtures/import-module/expected.js
"use strict";
require("element-ui/lib/abc/style.css");
var _abc = _interopRequireDefault(require("element-ui/lib/abc"));
function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
console.log(_abc["default"].Button);
console.log(_Element); I would expect something like |
It would be nice to unlock the version of @babel/* dependencies required by this module.
Related to: #44
The text was updated successfully, but these errors were encountered: