Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a contract causes deletion of all contracts of said creator #6

Open
Eitan-Lev opened this issue Oct 30, 2018 · 1 comment
Open
Labels
bug Something isn't working difficulty: medium

Comments

@Eitan-Lev
Copy link
Owner

When withdrawing both parties' funds, the factory.removeDeposit() is called, then delete deployedDeposits[(depositsCreators[msg.sender])] is done.
This deletes all the contracts belonging to sender, instead of just the specific one.
Tricky to fix- we work with an array, and don't want to leave an empty cell in the middle.

@Eitan-Lev Eitan-Lev added bug Something isn't working difficulty: medium labels Oct 30, 2018
@Eitan-Lev
Copy link
Owner Author

The index number is returned when performing push, so we can use it to save and later refer to it. Makes it relatively cheap.

@Eitan-Lev Eitan-Lev reopened this Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficulty: medium
Projects
None yet
Development

No branches or pull requests

1 participant