Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect.replicate appears under 'utils' instead of 'Collecting' #4074

Open
dmeehan1968 opened this issue Dec 4, 2024 · 3 comments
Open

Effect.replicate appears under 'utils' instead of 'Collecting' #4074

dmeehan1968 opened this issue Dec 4, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@dmeehan1968
Copy link

What is the type of issue?

No response

What is the issue?

Effect.replicate is out of sequence in the TOC, appearing under the 'utils' category.

Docstrings in the source seem to be correct (although the 'Category' is shown as 'collecting & elements' but this is the same as other functions which are appearing under the 'Collecting' category.

Where did you find it?

https://effect-ts.github.io/effect/effect/Effect.ts.html#replicate

@dmeehan1968 dmeehan1968 added the documentation Improvements or additions to documentation label Dec 4, 2024
@jessekelly881
Copy link
Contributor

Does Effect.replicate even need to exist when there is the more general Array.replicate?

@gcanti
Copy link
Contributor

gcanti commented Dec 5, 2024

Does Effect.replicate even need to exist when there is the more general Array.replicate?

Yeah, historically this function may have predated Array.replicate and has remained there without us noticing, but it's unnecessary.

In any case, it's a simple utility and doesn't belong in the "Collecting" category.

@mikearnaldi
Copy link
Member

Does Effect.replicate even need to exist when there is the more general Array.replicate?

no it doesn't, it's there due to history most likely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants