Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add it.{effect,live,scoped,scopedLive}.fails #3970

Open
lishaduck opened this issue Nov 20, 2024 · 1 comment · May be fixed by #3973
Open

Add it.{effect,live,scoped,scopedLive}.fails #3970

lishaduck opened this issue Nov 20, 2024 · 1 comment · May be fixed by #3973
Labels
enhancement New feature or request

Comments

@lishaduck
Copy link

What is the problem this feature would solve?

I'm writing @lishaduck/effect-platform-deno and am currently in the process of porting over @effect/platform-node-shared's tests. I've swapped them over to it.effect to make failures easier to read, but there's not a .fail function for when I know tests don't pass yet.

What is the feature you are proposing to solve the problem?

Add in the .fail function from vitest core.

What alternatives have you considered?

Skipping them.

@lishaduck lishaduck added the enhancement New feature or request label Nov 20, 2024
@lishaduck lishaduck changed the title Add it.effect.fails Add it.{effect,live,scoped,scopedLive}.fails Nov 20, 2024
@lishaduck
Copy link
Author

Oh, apparently I can pass an object to the timeout parameter and specify it there, but that's still overly verbose.

@lishaduck lishaduck linked a pull request Nov 20, 2024 that will close this issue
5 tasks
@lishaduck lishaduck moved this from Todo to In Progress in @lishaduck's todo list Nov 25, 2024
@lishaduck lishaduck moved this from In Progress to In Review in @lishaduck's todo list Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant